From 2e9873125c58796180101c255c121d3bbb865d11 Mon Sep 17 00:00:00 2001 From: Motiejus Viltrakis <36502659+iM0ve@users.noreply.github.com> Date: Thu, 24 Sep 2020 10:42:27 +0300 Subject: [PATCH] Replaced the checkbox list in whats tested section (#1948) Co-authored-by: Motiejus Viltrakis --- .github/PULL_REQUEST_TEMPLATE.md | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 57a3a0bc08a..ffff67805ab 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,7 +10,7 @@ ### Checklist for PR maker - [ ] Have you added a backport label (if needed)? For example, the `need-backport-*` label. After you backport the PR, the label changes to `backported-*`. - [ ] Have you updated the changelog? Each package has a `CHANGELOG.md` file. -- [ ] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the [Docs team contacts sheet](https://docs.google.com/spreadsheets/d/1rgUWWgwLFEHIQ3Rz-LnK6PAKmbM49DZZ9al4hvnztOo/edit#gid=1058860420). +- [ ] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the [Docs team contacts sheet](https://docs.google.com/spreadsheets/d/1rgUWWgwLFEHIQ3Rz-LnK6PAKmbM49DZZ9al4hvnztOo/edit#gid=1058860420). - [ ] Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test. --- @@ -19,22 +19,7 @@ Why is this PR needed, what hard problem is it solving/fixing? --- ### Testing status - -**Manual Tests**: What did you do? -- [ ] Opened test project + Run graphic tests locally -- [ ] Built a player -- [ ] Checked new UI names with UX convention -- [ ] Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset -- [ ] C# and shader warnings (supress shader cache to see them) -- [ ] Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths) -- Other: - -**Automated Tests**: What did you setup? (Add a screenshot or the reference image of the test please) - -**Yamato**: (Select your branch): -https://yamato.cds.internal.unity3d.com/jobs/902-Graphics - -Any test projects to go with this to help reviewers? +Describe what manual/automated tests were performed for this PR --- ### Comments to reviewers