Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenCensus support for Envoy 1.31 #10170

Open
andy-fong opened this issue Oct 4, 2024 · 2 comments
Open

Remove OpenCensus support for Envoy 1.31 #10170

andy-fong opened this issue Oct 4, 2024 · 2 comments

Comments

@andy-fong
Copy link
Contributor

andy-fong commented Oct 4, 2024

Do you have a suggestion for code improvement or tracking existing technical debt? Please describe.

Opencensus has been marked as deprecated for a while and it’s disabled by default in envoy 1.31. Config will be rejected by envoy if set.

Product Team agreed that we can remove opencensus support.

It does not appear that we have any e2e tests for Opencensus. We only have unit tests so it's not a hard blocker for upgrading to envoy 1.31. All tests should still pass without any changes.

If we need to allow this after upgrading to envoy 1.31, see the layered_runtime
section for example.

Envoy PR for this change: envoyproxy/envoy#33912

Our change log when we mentioned supprot for Opencensus.

We have api reference about it in solo.io.envoy.config.trace.v3 pkg from our doc

Eventually, we should comment out:
"envoy.tracers.opencensus": "//source/extensions/tracers/opencensus:config",
from bazel/extensions/extensions_build_config.bzl file.

Describe the solution you'd like

Do not compile in the opencensus extention.

Additional Context

No response

@nfuden
Copy link
Contributor

nfuden commented Oct 10, 2024

Not required for adopting 1.31. Is a good thing for us to do

@andy-fong
Copy link
Contributor Author

Do this in 1.19 just in case someone needs time to migrate but will document the layer_runtime config in 1.18 changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants