GatewayParameters imagePullSecrets definition unclear

[huzlak]

Gloo Edge Product

Enterprise

Gloo Edge Version

v1.17.3

Kubernetes Version

1.28

Describe the bug

When setting up gatewayparameters via helm chart, I can not specify imagePullSecrets, even though helm api reference states there is gloo.kubeGateway.gatewayParameters.glooGateway.envoyContainer.image.pullSecret this option seems to have no effect. In kubernetes this is defined per pod and based on gatewayparameters crd, there's no such configuration in the image section, but it should be part of podTemplate:

$ kubectl explain gatewayparameters.spec.kube.envoyContainer.image
GROUP:      gateway.gloo.solo.io
KIND:       GatewayParameters
VERSION:    v1alpha1

FIELD: image <Object>

DESCRIPTION:
    <empty>
FIELDS:
  digest	<string>
    <no description>

  pullPolicy	<string>
    <no description>

  registry	<string>
    <no description>

  repository	<string>
    <no description>

  tag	<string>
    <no description>

$ kubectl explain gatewayparameters.spec.kube.podTemplate
GROUP:      gateway.gloo.solo.io
KIND:       GatewayParameters
VERSION:    v1alpha1

FIELD: podTemplate <Object>

DESCRIPTION:
    <empty>
FIELDS:
  affinity	<Object>
    <no description>

  extraAnnotations	<map[string]string>
    <no description>

  extraLabels	<map[string]string>
    <no description>

  imagePullSecrets	<[]Object>
    <no description>

  nodeSelector	<map[string]string>
    <no description>

  securityContext	<Object>
    <no description>

  tolerations	<[]Object>
    <no description>

Our chart is missing that in the podTemplate so it's currently not possible to define pullsecret via helm

Expected Behavior

I'd like to have an option to set the image pull secret for the gateway pods via helm chart

Steps to reproduce the bug

1. Install gloo gw with values:

  kubeGateway:
    enabled: true
    gatewayParameters:
      glooGateway:
        envoyContainer:
          image:
            pullSecret: secret

2. See that no pull secret is set for the gateway pods
3. Add below into podTemplate inside gatewayparameters manually:

imagePullSecrets:
- name: secret

4. Pods have the imagePullSecret set now

Additional Environment Detail

No response

Additional Context

No response