Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lottie-player from website #6874

Closed
iskyOS opened this issue Apr 16, 2024 · 2 comments · Fixed by #6888
Closed

Remove lottie-player from website #6874

iskyOS opened this issue Apr 16, 2024 · 2 comments · Fixed by #6888
Assignees
@gitstart-sourcegraph
Labels
Low priority Has minimal consequences if delayed.

Comments

@iskyOS
Copy link
Contributor

iskyOS commented Apr 16, 2024

Follow up to this task: #6777

Can we please remove lottie-web based on the third-party code audit?

This was mentioned in the audit:

lottie-web: Can be removed. It's used in the src/components/LottiePlayer.tsx component which it's not used anywhere
@iskyOS iskyOS added the Low priority Has minimal consequences if delayed. label Apr 16, 2024
@gitstart-app GitStart App
Copy link
Contributor

gitstart-app bot commented Apr 16, 2024

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/sourcegraph/3436/tickets/SGM-6874

@gitstart-app gitstart-app bot mentioned this issue Apr 19, 2024
Merged
@gitstart-sourcegraph gitstart-sourcegraph linked a pull request Apr 19, 2024 that will close this issue
SGM-6874 - Remove lottie-player from website #6888
Merged
@iskyOS
Copy link
Contributor Author

iskyOS commented Apr 25, 2024

Looks good and merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitstart-sourcegraph gitstart-sourcegraph

Labels
Low priority Has minimal consequences if delayed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SGM-6874 - Remove lottie-player from website sourcegraph/about
2 participants
@iskyOS @gitstart-sourcegraph