-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resources that deal with passwords need the sensitive flag #40
Comments
Pull request 41 |
I will review your code tonight, but i just discovered this option. Thx for your PR! |
I close the issue, as the PR is merged. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
For example, there are several places calling the command line and passing the root password in the clear:
https://github.com/sinfomicien/mariadb/blob/935522ed6e6bae0749b0ecb5a5d713bbf08a02d3/providers/replication.rb#L56
and line 70, 84, 98.
https://github.com/sinfomicien/mariadb/blob/935522ed6e6bae0749b0ecb5a5d713bbf08a02d3/recipes/_redhat_galera.rb#L39
https://github.com/sinfomicien/mariadb/blob/935522ed6e6bae0749b0ecb5a5d713bbf08a02d3/recipes/_redhat_server.rb#L35
https://github.com/sinfomicien/mariadb/blob/e7412244dcce3b276fd6a1b7ccf68a8d691e2d2e/recipes/galera.rb#L119
and line 124.
This is dependent upon: chef/chef#2013 which is in Chef 11.14
Looks like foodcritic still does not have full support for this: Foodcritic/foodcritic#233
will have to backout the execute changes for now
The text was updated successfully, but these errors were encountered: