New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(snippets): hide lyrics button #600

Merged

theRealPadster merged 7 commits into spicetify:main from Sakura125809:main

Oct 4, 2023

Contributor

Sakura125809 commented Sep 23, 2023

No description provided.


          Add hide lyrics button snippet

4f28e49

Sakura125809 requested a review from a team as a code owner

September 23, 2023 05:53

Sakura125809 requested review from theRealPadster and removed request for a team

September 23, 2023 05:53

Sakura125809 changed the title ~~Add hide lyrics button snippet~~ feat: Add hide lyrics button snippet

Sakura125809 changed the title ~~feat: Add hide lyrics button snippet~~ feat(snippets): Hide lyrics button snippet

Sakura125809 changed the title ~~feat(snippets): Hide lyrics button snippet~~ feat(snippets): hide lyrics button snippet

Sakura125809 changed the title ~~feat(snippets): hide lyrics button snippet~~ feat(snippets): hide lyrics button

Member

CharlieS1103 commented Oct 1, 2023

I think this might be better suited as a toggle in the better lyrics setting menu, I would recommend making a PR implementing that yourself or making an issue requesting the maintainer of better lyrics to do so. Let me know what you think though.

Member

rxri commented Oct 2, 2023

Snippets shouldn't be extension dependent. Please make PR to betterLyrics repo

rxri closed this

Contributor Author

Sakura125809 commented Oct 2, 2023

I think this might be better suited as a toggle in the better lyrics setting menu, I would recommend making a PR implementing that yourself or making an issue requesting the maintainer of better lyrics to do so. Let me know what you think though.

I’m very sorry, but Spotify lyrics vary greatly by region, resulting in many songs without lyrics. For me (and maybe others have the same demand), the lyrics button is often useless, so I developed this snippet to remove this button.

Contributor Author

Sakura125809 commented Oct 2, 2023

Snippets shouldn't be extension dependent. Please make PR to betterLyrics repo

As I answered CharlieS1103, I can delete the part about better lyrics (you can too, because I turned on the Allow edits by maintainers button). This snippet only removes the native lyrics button, because many songs are limited by region and have no lyrics.

rxri reopened this

Sakura125809 added 3 commits

October 2, 2023 19:38


          Merge branch 'main' into main

b3088ad


          Add hide lyrics button

d0b7e05


          Merge branch 'main' into main

edbc130

Sakura125809 marked this pull request as draft

October 3, 2023 14:04


          remove the part of better lyrics

61e229d

Sakura125809 marked this pull request as ready for review

October 3, 2023 14:10


          Fix the syntax errors.

db7f908

theRealPadster requested changes

View reviewed changes

src/resources/snippets.ts Outdated Show resolved Hide resolved


          cleaner code

f7e75bf

Sakura125809 requested a review from theRealPadster

October 4, 2023 00:37

theRealPadster approved these changes

View reviewed changes

Member

theRealPadster left a comment

Nice that looks better, thanks

theRealPadster merged commit 286701e into spicetify:main

5 checks passed

Contributor

SunsetTechuila commented Oct 4, 2023 •

edited

Loading

this snippet also hides the right sidebar and queue buttons🤦‍♂️

Contributor

SunsetTechuila commented Oct 4, 2023

selector should be .main-nowPlayingBar-lyricsButton

Contributor Author

Sakura125809 commented Oct 4, 2023

selector should be .main-nowPlayingBar-lyricsButton

Yes, this is an oversight on my part and I will correct it immediately. thank you for pointing out. :)

Sakura125809 mentioned this pull request

fix(snippets): hide lyrics button #606

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment