Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable use_enum_values #266

Open
cmcginley-splunk opened this issue Aug 27, 2024 · 0 comments
Open

Disable use_enum_values #266

cmcginley-splunk opened this issue Aug 27, 2024 · 0 comments

Comments

@cmcginley-splunk
Copy link
Collaborator

  • Auto-converting enums to their string values in Pydantic leads to typing weirdness and some inconsistent logical checks
  • We should:
    • removes all instances of use_enum_values from the codebase
    • identifies wherever the .value is used and removes them, if applicable
    • Runs validate /build --enrichments / test to make sure everything "seems to work" AND produces the same output files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant