Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace Updates #6

Closed
LBRapid opened this issue Nov 28, 2011 · 4 comments
Closed

Namespace Updates #6

LBRapid opened this issue Nov 28, 2011 · 4 comments

Comments

@LBRapid
Copy link
Contributor

LBRapid commented Nov 28, 2011

Hello there, so I made some changes recently to get this extension working with Spree 0.80.x and above. joneslee85, not sure if you had been doing similar work locally or not but I pushed to master when I initially started working on these changes, so I've sort of stuck with it.

I still need to take a look at the specs, but as far as functionality goes I believe the extension is working except for updating captcha settings in the admin interface. I took a look at that issue but couldn't see exactly what was wrong there.

Remaining work:

  • Get specs passing (rake test_app seems to break due to changes in spree almost every time I get it running again, not sure what the current deal is)
  • Fix setting of Spree::Captcha::Config at app/controllers/spree/admin/captcha_settings_controller.rb:5
@runlevel5
Copy link

@LBRapid: I haven't touched it for a while, I'd really appreciate your help on porting it to work with 0.80.x

@jsqu99
Copy link

jsqu99 commented Dec 4, 2011

Hi Guys,

I think the Versionfile needs to be updated for spree 0.70-x.

I had trouble figuring out the first namespace commit, but right around commit: 16f53be

is the last spree 70 working version, I believe (about to test).

In other words, should probably change the spree 0.80 to master and 0.70 to something near this commit.

Thanks,

Jeff

@runlevel5
Copy link

Yup, we have to add 1.0.0 in Versionfile. Please let me know which commit is the last commit working for 0.70.

@JDutil
Copy link
Member

JDutil commented Dec 5, 2011

The last commit that will work with 0.70.x is:

aa68252

I'll update Versionfile shortly.

@JDutil JDutil closed this as completed in 89d2eaf Dec 5, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants