Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash while processing payments leads to unexpected behavior #10744

Open
project-concerto opened this issue Jan 30, 2021 · 0 comments
Open

Crash while processing payments leads to unexpected behavior #10744

project-concerto opened this issue Jan 30, 2021 · 0 comments

Comments

@project-concerto
Copy link

Context

Assuming some user is paying with store credits, if the application crashes during processing payments, the order has some unexpected behavior after the application restarts.

Unexpected Behavior 1

If the user resumes checkout by going to /checkout, he cannot proceed and spree prompts "no payment found".

Unexpected Behavior 2

If the user adds another item to cart and click checkout, his credit won't be deducted for the initial item.

Possible Cause

After crash, the initial checkout's payment won't be re-processed.

Thus for [Unexpected Behavior 1], there is no payment to process. For [Unexpected behavior 2] only payment for newly added item will be processed.

Steps to Reproduce

We can use the following code which adds a exit to simulate a application crash:
project-concerto@144b35f

Your Environment

  • Version used: master
  • Gemfile and Gemfile.lock as text in a Gist: just the provided sandbox application
  • Any relevant stack traces ("Full trace" preferred): None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants