Cancelling orders where payment has no response code

[jackbot]

One of our payment methods is Paypal which doesn't seem to give a response code when making a transaction, so the payment is saved with no response_code. This is causing issues when cancelling an order, which in turn cancels the payment and calls this line

https://github.com/spree/spree/blob/master/core/app/models/spree/payment/processing.rb#L73

Within the payment method cancel method, we have nil as the response_code and so there's no way to know which payment we're trying to cancel. I assume other payment gateways will find the payment in the database by searching against response_code but I'm thinking it would be useful to pass the payment_id into this method too.

[JDutil]

Perhaps it should be updated to pass an options hash, and payment_id can be sent as an option. Probably response_code should be sent as an option as well. I can imagine many scenarios where just the response code wouldn't be sufficient like bitcoin or apple pay too probably.