Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair Zipkin Micrometer Tracing #223

Closed
arey opened this issue Feb 20, 2023 · 10 comments
Closed

Repair Zipkin Micrometer Tracing #223

arey opened this issue Feb 20, 2023 · 10 comments
Labels

Comments

@arey
Copy link
Member

arey commented Feb 20, 2023

It seems that since the upgrade to Spring Cloud 2022.0, the OpenZipkin server is no longer receiving the traces.
We should use Micrometer to trace your Spring Boot app: https://springbootlearning.medium.com/using-micrometer-to-trace-your-spring-boot-app-1fe6ff9982ae

@arey arey added the bug label Feb 20, 2023
@MarianConstantinMarica
Copy link
Contributor

Can I work on this issue?

@arey
Copy link
Member Author

arey commented Mar 11, 2023

Yes @MarianConstantinMarica you can work on this issue. Thank you for the proposal.

@dgriffiths-undo
Copy link

Ah, is this why I don't see any traces? I just downloaded the latest master and ran using scripts/run_all.sh and expected traces to magically appear at http://localhost:9411/zipkin/ but nothing appears. Any idea what the last working branch was?

@arey
Copy link
Member Author

arey commented Mar 17, 2023

@dgriffiths-undo
Copy link

Ok that works, thanks!

@MarianConstantinMarica
Copy link
Contributor

I sent the PR

@arey
Copy link
Member Author

arey commented Mar 21, 2023

Thanks @MarianConstantinMarica I've just posted a single comment. Once merged, @dgriffiths-undo could you please test it?

@arey
Copy link
Member Author

arey commented Mar 21, 2023

@marcingrzejszczak I saw you are working on Micrometer. Thus could you have a look on this PR please?

@marcingrzejszczak
Copy link
Contributor

Of course

@arey arey closed this as completed Aug 21, 2023
@arey
Copy link
Member Author

arey commented Aug 21, 2023

Fixed by @MarianConstantinMarica

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants