-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair Zipkin Micrometer Tracing #223
Comments
Can I work on this issue? |
Yes @MarianConstantinMarica you can work on this issue. Thank you for the proposal. |
Ah, is this why I don't see any traces? I just downloaded the latest master and ran using |
@dgriffiths-undo you may try the previous version: https://github.com/spring-petclinic/spring-petclinic-microservices/tree/v2.6.7 |
Ok that works, thanks! |
I sent the PR |
Thanks @MarianConstantinMarica I've just posted a single comment. Once merged, @dgriffiths-undo could you please test it? |
@marcingrzejszczak I saw you are working on Micrometer. Thus could you have a look on this PR please? |
Of course |
Fixed by @MarianConstantinMarica |
It seems that since the upgrade to Spring Cloud 2022.0, the OpenZipkin server is no longer receiving the traces.
We should use Micrometer to trace your Spring Boot app: https://springbootlearning.medium.com/using-micrometer-to-trace-your-spring-boot-app-1fe6ff9982ae
The text was updated successfully, but these errors were encountered: