Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<tab> key to move to next filter #106

Closed
maxslimmer opened this issue Sep 18, 2014 · 14 comments
Closed

<tab> key to move to next filter #106

maxslimmer opened this issue Sep 18, 2014 · 14 comments
Labels
enhancement Feature requests.

Comments

@maxslimmer
Copy link

On the Browse Data tab: It would really enhance keyboard navigation to have either (or) both the 'enter' and 'tab' keys move input focus to the next filter field. Currently 'tab' moves to the next data cell and 'enter' does nothing.

@justinclift justinclift added the enhancement Feature requests. label Sep 19, 2014
@justinclift
Copy link
Member

Yeah, this sounds like a good idea. 😄

MKleusberg added a commit that referenced this issue Oct 11, 2014
Allow jumping between the filter input fields by pressing Tab and
Shift+Tab.

See issue #106.
@MKleusberg
Copy link
Member

Should be fixed now - with the latest build you can press Tab or Shift+Tab to jump between the filters.

@justinclift
Copy link
Member

@maxslimmer Would you have a few minutes to try the latest nightly build (tomorrow), to verify this works properly for you now? 😄

Not sure which OS you're on, so Windows nightly builds are here:

    http://rp.oldsch00l.com/sqlitebrowser/

OSX nightly builds are here:

    http://mirror.salasaga.org/sqlitebrowser/nightly/

@maxslimmer
Copy link
Author

Absolutely. I looked for a build last night but I was still a little early
(still @ 0177155). I'll try it now.

@maxslimmer
Copy link
Author

@justinclift Just downloaded the sqlitebrowser.exe.xz from the oldsch00l link you provided, renamed it sqlitebrowser.exe (assumed that's the thing to do) and tried to run it. Produced following
untitled
I'm running Windows 7, 64bit.

@maxslimmer
Copy link
Author

And I'm still early. Build log indicates its still 0177155. I'll wait till tomorrow.

@glawrence
Copy link
Contributor

The file sqlitebrowser.exe.xz is actually an archive file, so you need to extract the exe from the archive before running. I suggest something like 7-Zip (http://www.7-zip.org/) for doing the extract. I just tried this and it worked fine for me.

@justinclift
Copy link
Member

Thanks Geoff, I forgot to mention it needs uncompressing first. 😄

@maxslimmer
Copy link
Author

I didn't recognize the suffix and somehow my brain went to it being an
obfuscation to fool virus scanners.
Bottom line, tabbing between filter field works as I'd expect. Enter still
does nothing, not sure if that's important.
Thank you for making these kinds of improvements, it makes the tool awesome.

@justinclift
Copy link
Member

@maxslimmer No worries, thanks for testing. 😄

@MKleusberg Should we do something with the enter key for this? eg same behaviour as tab, or maybe it also moves the cursor to the start of next line or something?

@MKleusberg
Copy link
Member

I haven't done anything with the enter key yet because personally I'd expect it to perform some real action and not just move the cursor. So what I thought was that if we're ever going to add some other feature and bind it to the enter key, we don't break any workflows when we don't use it now ;) It wouldn't be difficult however to support the enter key as well if people would like.

@justinclift
Copy link
Member

Yeah, I guess the question is "what do we want enter to do?".

I'm thinking the equivalent of the tab key sounds ok... but yeah, that could just be my limited imagination atm, and someone might have a better idea. 😉

@maxslimmer @glawrence @Z4us Any thoughts on this? 😄

@maxslimmer
Copy link
Author

I could go either way. The filter gets applied on each character keypress so it's not like is required to start the filter. Plus back tabbing is supported with shift + Tab whereas using Enter to move between fields would imply Shift + Enter for moving backward and that does not seem idomatic.
I guess I lean toward leaving Enter unmapped.

@justinclift
Copy link
Member

Cool, no worries. We'll leave Enter alone for now, until someone comes up with a Nifty use for it. 😉

Closing this issue now too, as the tab key binding bit is resolved. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests.
Projects
None yet
Development

No branches or pull requests

4 participants