Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group package set related options #72

Closed
srid opened this issue Feb 8, 2023 · 2 comments
Closed

Group package set related options #72

srid opened this issue Feb 8, 2023 · 2 comments
Labels
api-change question Further information is requested

Comments

@srid
Copy link
Owner

srid commented Feb 8, 2023

Detached from #52 (comment)

haskellProjects.foo = {
  devShell.enable = false;
  packageSet = {
    # The overlays are composed in the order they are shown here.
    base = pkgs.haskell.packages.ghc944;
    local = {
      mypkg.root = ./.;  # Assumes mypkg.cabal
    };
    source-overrides = { .. }; # Overrides by direct path to source
    overrides = self: super:  { .. };  # Raw Haskell overlay
  };
};

Users can then use config.haskellPackages.foo.packageSet.final to access all the packages. The idea is that we can say "start from base", then we apply local, then source-overrides and finally overrides, before creating the project specific haskell package set.

finalPackages of #68 would become packageSet.final.

@roberth
Copy link
Collaborator

roberth commented Feb 9, 2023

I'm not convinced yet, because it makes the syntax a little bit more complicated. I think of a haskellProject as a package set, and if I need more than one package set, I need to use multiple projects anyway.

We don't have a module for warnings / assertions support yet, but that could be added in flake-parts.

@srid srid added question Further information is requested api-change and removed DX Developer Experience labels Feb 9, 2023
@srid
Copy link
Owner Author

srid commented Feb 10, 2023

because it makes the syntax a little bit more complicated. I think of a haskellProject as a package set, and if I need more than one package set, I need to use multiple projects anyway.

That's fair.

@srid srid closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants