Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boston Housing re-uses attribute names in different type fields #19

Closed
hayesall opened this issue Jun 6, 2022 · 1 comment
Closed
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@hayesall
Copy link
Member

hayesall commented Jun 6, 2022

It would probably be good to revisit this dataset:

  • Create standard cross validation folds
  • Make datasets with relational_datasets.from_numpy

Currently reusing attribute names in different type fields, e.g.:

age(id100,1).
age(id101,2).
age(id10,2).
age(id102,4).
age(id103,2).
% ...
b(id97,2).
b(id98,1).
b(id99,2).
chas(id1,0).
chas(id10,0).
chas(id100,0).

Causes issues like the following:

%   *** WARNING ***  Constant '1' is already marked as being of types = [varsrim];
%          type = 'varindus' may be added if not already known.
%  PredicateName = 'indus', from 'indus(id100, 1)',
%  which has types = [signature = [const, const], types = [+id, #varindus]]
%   Other warnings with this predicate and this new type are not reported in order to keep this printout small.  Use dontComplainAboutMultipleTypes to override.

%   *** WARNING ***  Constant '0' is already marked as being of types = [varzn];
%          type = 'varchas' may be added if not already known.
%  PredicateName = 'chas', from 'chas(id1, 0)',
%  which has types = [signature = [const, const], types = [+id, #varchas]]
%   Other warnings with this predicate and this new type are not reported in order to keep this printout small.  Use dontComplainAboutMultipleTypes to override.

%   *** WARNING ***  Constant '2' is already marked as being of types = [varsrim, varindus];
%          type = 'varnox' may be added if not already known.
%  PredicateName = 'nox', from 'nox(id100, 2)',
%  which has types = [signature = [const, const], types = [+id, #varnox]]
%   Other warnings with this predicate and this new type are not reported in order to keep this printout small.  Use dontComplainAboutMultipleTypes to override.

%   *** WARNING ***  Constant '3' is already marked as being of types = [varsrim, varindus, varnox];
%          type = 'varrm' may be added if not already known.
%  PredicateName = 'rm', from 'rm(id100, 3)',
%  which has types = [signature = [const, const], types = [+id, #varrm]]
%   Other warnings with this predicate and this new type are not reported in order to keep this printout small.  Use dontComplainAboutMultipleTypes to override.

%   *** WARNING ***  Constant '1' is already marked as being of types = [varsrim, varindus, varchas, varnox, varrm];
%          type = 'varage' may be added if not already known.
%  PredicateName = 'age', from 'age(id100, 1)',
%  which has types = [signature = [const, const], types = [+id, #varage]]
%   Other warnings with this predicate and this new type are not reported in order to keep this printout small.  Use dontComplainAboutMultipleTypes to override.

%   *** WARNING ***  Constant '4' is already marked as being of types = [varsrim, varindus, varnox, varrm, varage];
%          type = 'vardis' may be added if not already known.
%  PredicateName = 'dis', from 'dis(id100, 4)',
%  which has types = [signature = [const, const], types = [+id, #vardis]]
%   Other warnings with this predicate and this new type are not reported in order to keep this printout small.  Use dontComplainAboutMultipleTypes to override.

%   *** WARNING ***  Constant '2' is already marked as being of types = [varsrim, varindus, varnox, varrm, varage, vardis];
%          type = 'varrad' may be added if not already known.
%  PredicateName = 'rad', from 'rad(id100, 2)',
%  which has types = [signature = [const, const], types = [+id, #varrad]]
%   Other warnings with this predicate and this new type are not reported in order to keep this printout small.  Use dontComplainAboutMultipleTypes to override.

%   *** WARNING ***  Constant '2' is already marked as being of types = [varsrim, varindus, varnox, varrm, varage, vardis, varrad];
%          type = 'varptrat' may be added if not already known.
%  PredicateName = 'ptratio', from 'ptratio(id100, 2)',
%  which has types = [signature = [const, const], types = [+id, #varptrat]]
%   Other warnings with this predicate and this new type are not reported in order to keep this printout small.  Use dontComplainAboutMultipleTypes to override.

%   *** WARNING ***  Constant '1' is already marked as being of types = [varsrim, varindus, varchas, varnox, varrm, varage, vardis, varrad, varptrat];
%          type = 'varb' may be added if not already known.
%  PredicateName = 'b', from 'b(id100, 1)',
%  which has types = [signature = [const, const], types = [+id, #varb]]
%   Other warnings with this predicate and this new type are not reported in order to keep this printout small.  Use dontComplainAboutMultipleTypes to override.

%   *** WARNING ***  Constant '1' is already marked as being of types = [varsrim, varindus, varchas, varnox, varrm, varage, vardis, varrad, varptrat, varb];
%          type = 'varlstat' may be added if not already known.
%  PredicateName = 'lstat', from 'lstat(id100, 1)',
%  which has types = [signature = [const, const], types = [+id, #varlstat]]
%   Other warnings with this predicate and this new type are not reported in order to keep this printout small.  Use dontComplainAboutMultipleTypes to override.
@hayesall
Copy link
Member Author

hayesall commented Nov 2, 2022

Deprecated Boston Housing in #23.

This may still cause problems, but I won't fix this.

@hayesall hayesall closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant