Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change raw pointers to unique_ptr for static variables in new ELI #394

Open
jjwilke opened this issue Apr 9, 2019 · 2 comments
Open

Change raw pointers to unique_ptr for static variables in new ELI #394

jjwilke opened this issue Apr 9, 2019 · 2 comments
Assignees
@jjwilke
Labels
SST-Core
Milestone
Future

Comments

@jjwilke
Copy link
Contributor

jjwilke commented Apr 9, 2019

This is a general cleanup of memory leaked at the end of the simulation so that valigrind/leak sanitizer are happy
@jjwilke jjwilke self-assigned this Apr 9, 2019
@jjwilke jjwilke changed the title Change raw pointers to unique_ptr for static variables Change raw pointers to unique_ptr for static variables in new ELI Apr 9, 2019
@jjwilke
Copy link
Contributor Author

jjwilke commented Apr 14, 2019

We need to be careful with this for El Capitan/XC8. There are compiler issues with unique_ptr and static initialization.

@jjwilke
Copy link
Contributor Author

jjwilke commented Mar 25, 2020

Related to #390. This requires significant modifications to library unloading to avoid segfaults (related to #443) by cleaning things out before we call dlclose.

@jjwilke jjwilke mentioned this issue Mar 25, 2020
Open
@allevin allevin added this to the Future milestone Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjwilke jjwilke

Labels
SST-Core
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@jjwilke @allevin