Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to specify which map renderer to use for styles that could be rendered with mulitple renderers #147

Closed
ebrelsford opened this issue Jan 17, 2023 · 9 comments · Fixed by #152
Assignees

Comments

@ebrelsford
Copy link
Contributor

Part of stamen/carto-tools#67.

Related to #146.

Currently the only way to specify which map renderer a style should use is via the configuration file for a Maperture deployment. We should add a way to switch between renderers in the UI.

Considerations

Acceptance criteria

  • When it is possible to render a style with multiple renderers, a user can switch between those renderers in the UI
  • The chosen renderer should be saved in the URL parameters with the rest of the state of the application
  • Changes to the configuration file should be backwards compatible
  • The user should be able to do this with styles loaded via URL, too
@kelsey-taylor kelsey-taylor self-assigned this Jan 18, 2023
@kelsey-taylor
Copy link
Collaborator

going to take a pass at this design (in conjunction with #146) and review with @ebrelsford later this week

@kelsey-taylor
Copy link
Collaborator

I've been noodling on these for a few days and here are the options I've come up with:

image

pros of either option:

  • clearly see what render is in use in each pane
  • clearly see if other renderers are/aren't available for each style
  • renderer visible regardless of view type (swipe/mirror/phone/responsive)
  • excluded from image copy (unless you want to include it, in which case you can screenshot manually)
  • easy to switch renderers if the configuration for that map allows for it

cons:

  • renderer not automatically included in image copy

Between the two, my preference is definitely for the dropdown, as it allows us to easily expand to additional renderers without taking up additional space in the UI. It does make the UI a little dropdown-heavy, but I don't think that's a big deal personally.

Would love thoughts/feedback/questions @ebrelsford @aparlato!

@ebrelsford
Copy link
Contributor Author

This is similar to what I had in mind, thanks for sketching out the options! Definitely leaning toward the dropdown version for flexibility.

Do you think there's any need to move to a separate settings panel? Just imagining the (minimal) extra space this will take up when you have 4+ map panes...

@kelsey-taylor
Copy link
Collaborator

I was thinking the same thing @ebrelsford! I'm inclined to start with this and then minimize if we find that they panes are too crowded - what do you think?

@ebrelsford
Copy link
Contributor Author

Works for me.

@kelsey-taylor kelsey-taylor removed their assignment Jan 23, 2023
@kelsey-taylor
Copy link
Collaborator

Great! Let's proceed with the dropdown option then. Going to unassign myself here as this is ready for implementation.

@ebrelsford ebrelsford self-assigned this Jan 24, 2023
@ebrelsford
Copy link
Contributor Author

I'm still working on this (in #152) but @kelsey-taylor I'm wondering what you think about how this feels so far?

image

I'm tempted to make the renderer dropdown more explicit, say, "Rendered with ".

@kelsey-taylor
Copy link
Collaborator

looking great so far! i'm definitely on board with adding a "rendered with" - maybe we could make that header a bit smaller than the style name.

threw a couple quick options together - i think i prefer the second

Screenshot 2023-01-31 at 11 30 15 AM

@ebrelsford
Copy link
Contributor Author

Yeah I think the second would be good, same page!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants