-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to specify which map renderer to use for styles that could be rendered with mulitple renderers #147
Comments
going to take a pass at this design (in conjunction with #146) and review with @ebrelsford later this week |
I've been noodling on these for a few days and here are the options I've come up with: pros of either option:
cons:
Between the two, my preference is definitely for the dropdown, as it allows us to easily expand to additional renderers without taking up additional space in the UI. It does make the UI a little dropdown-heavy, but I don't think that's a big deal personally. Would love thoughts/feedback/questions @ebrelsford @aparlato! |
This is similar to what I had in mind, thanks for sketching out the options! Definitely leaning toward the dropdown version for flexibility. Do you think there's any need to move to a separate settings panel? Just imagining the (minimal) extra space this will take up when you have 4+ map panes... |
I was thinking the same thing @ebrelsford! I'm inclined to start with this and then minimize if we find that they panes are too crowded - what do you think? |
Works for me. |
Great! Let's proceed with the dropdown option then. Going to unassign myself here as this is ready for implementation. |
I'm still working on this (in #152) but @kelsey-taylor I'm wondering what you think about how this feels so far? I'm tempted to make the renderer dropdown more explicit, say, "Rendered with ". |
Yeah I think the second would be good, same page! |
Part of stamen/carto-tools#67.
Related to #146.
Currently the only way to specify which map renderer a style should use is via the configuration file for a Maperture deployment. We should add a way to switch between renderers in the UI.
Considerations
Acceptance criteria
The text was updated successfully, but these errors were encountered: