-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manual with new log_mix functionality #134
Comments
Updates to the manual should go with the PR that adds the new functions. We need to be checking that in code review in stan-dev/stan. If the new functions have already been merged, then we'll have to do this through a separate PR. If they haven't been merged, then the manual updates shold be part of the PR for adding the function. |
Can we get There's possibly some confusion (at least on my end) about how the manual specifies the erroneous attempt to vectorize mixtures with this "vectorized" implementation that I would like cleared up. |
I'm not even sure what the signature is here. I'm tagging @WardBrian who's been cleaning up all of our doc and should be able to figure out from the OCaml code what exactly is supported in the way of signatures. I've used shorthand to describe complicated signatures, like And yes, rewriting examples in the doc that use |
Sorry, this was one that I should have done a long time ago. If it's helpful, an example of the usage is in the example models repo here: https://github.com/stan-dev/example-models/blob/master/basic_estimators/normal_mixture_k.stan Also, some discussion of the usage/syntax are in these comment threads from the original PRs: |
The supported signatures in stanc3 are:
I think the standard we use is to list the original function and then use the Though functions like beta seem to be much more vectorized than log_mix is. Here are all it's valid signatures in stanc3: https://gist.github.com/WardBrian/0498ea88312fed7de4a3eaa439e6ec2c |
Summary:
New log_mix functions allow for use with vectors and arrays (as opposed to the current version which is a ternary scalar function), need to update the manual to reflect this (both in terms of function signatures and examples).
Description:
I'm writing up changes to the manual to add the new signatures for
log_mix
(as in stan-dev/stan#2532).(real theta, real lp1, real lp2)
(page 455), should I add the new signatures here or should I make a new entry in 'Matrix Operations'?log_sum_exp
for mixtures with more than two components, should I rewrite these to uselog_mix
or leave that for a separate pull?Current Version:
v2.17.1
The text was updated successfully, but these errors were encountered: