Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider Makefile including config from $HOME #3088

Closed
WardBrian opened this issue Jun 20, 2024 · 1 comment · Fixed by #3090
Closed

Reconsider Makefile including config from $HOME #3088

WardBrian opened this issue Jun 20, 2024 · 1 comment · Fixed by #3090

Comments

@WardBrian
Copy link
Member

Description

Stan's makefiles include custom configuration from a couple locations.

The first is make/local, and this is what we document and recommend using.

The second is a sub-directory of $HOME:

math/makefile

Line 14 in 4c626fd

-include $(HOME)/.config/stan/make.local # user-defined variables

This can cause issues when HOME has a space in the path (found by @andrjohns)

I don't think we document this file anywhere, and I also think that allowing a global config like this is probably a bad idea in general.

Current Version:

v4.9.0
@SteveBronder
Copy link
Collaborator

idk anyone that uses this so I'm pretty for removing it

@WardBrian WardBrian mentioned this issue Jun 24, 2024
Merged
4 tasks
@WardBrian WardBrian mentioned this issue Jul 1, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for ~/.config makefile inclusion stan-dev/math
2 participants
@SteveBronder @WardBrian