-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a rubocop-rails ruleset #266
Comments
If there's one thing I learned using rubocop-rails it's that it's not all that great at determining what is or isn't a Rails app. It's not awful at it, and I'm sure it will be helpful, but don't look to it as a goal. |
Thanks for the advice |
Maybe for This way from a |
I think that this is the right architectural perspective, but after discussing with a lot of users of rubocop-rails, I've not found very many endorsements that it would be worthwhile (put differently, I haven't seen much evidence that an opinionated, fixed ruleset could be chosen and meet our expectations for universality, consistency, and reasonability). I'll take a second look |
Thank you for your quick anwer and explanation. I think it would still be worthwile to have an opinionated ruleset, even if it does not meet the high standards in the beginning, compared to having no ruleset at all. One of the big advantages still is not having to argue about rules if there is one standard 👍 |
I can't wait to start using standard-rails and others given the recent update 🙌 |
@xdmx stay tuned! Should have something to share in the next couple months |
[rubocop-rails(https://github.com/rubocop/rubocop-rails) has come a long way since we started the Standard project, and there's a lot in it that I think Standard could benefit from.
My approach to integrating it would look a lot like how we incorporate rubocop-performance, currently. However, there are a couple wrinkles:
>=
—could create transitive pain for some users. We should investigate ways of enabling it without adding it as a hard runtime dep for all users all the time.Thoughts?
The text was updated successfully, but these errors were encountered: