Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code coverage badge problem #28

Closed
allevo opened this issue Mar 14, 2019 · 3 comments
Closed

Code coverage badge problem #28

allevo opened this issue Mar 14, 2019 · 3 comments

Comments

@allevo
Copy link

allevo commented Mar 14, 2019

For the time being the code coverage is 0. Why?

image
@pscanf
Copy link
Member

pscanf commented Mar 14, 2019

Ah, should be because of this bug in yarn (or maybe nyc). Basically when running yarn coverage process pid-s are not passed correctly and that results in nyc returning 0% coverage. I should be fixable by changing yarn coverage to npm run coverage here.

I never bothered to do it, but I'll try now. 🙂

@pscanf
Copy link
Member

pscanf commented Mar 14, 2019

See #29

@pscanf pscanf mentioned this issue Mar 14, 2019
Merged
@pscanf pscanf closed this as completed in f935093 Mar 14, 2019
@pscanf
Copy link
Member

pscanf commented Mar 14, 2019

Thanks for the heads up! Looks better now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@allevo @pscanf