advanced cljs compilation #8285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasom
requested review from
antdanchenko,
churik,
jakubgs,
vkjr and
a team
as code owners
|
|
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (112)
|
|
|
rasom
changed the title
|
|
2 similar comments
|
|
|
|
|
|
43% of end-end tests have passedFailed tests (28)Click to expand
Passed tests (21)Click to expand |
|
|
78% of end-end tests have passedFailed tests (11)Click to expand
Passed tests (38)Click to expand
|
can be reproduced in nightly |
|
@Serhy all issues except 2) should be fixed now |
jakubgs
reviewed
May 29, 2019
96% of end-end tests have passedFailed tests (2)Click to expand
Passed tests (47)Click to expand |
94% of end-end tests have passedFailed tests (3)Click to expand
Passed tests (46)Click to expand |
|
With Galaxy Note 4:
@rasom, there is a regression appeared with latest changes:
PNs are working fine in nightly (30th of May) build |
|
@Serhy it is built without some optimizations at the moment, so it might be slightly faster in the next release |
pushed a fix |
|
Perfect! Thanks @rasom! PN works for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds advanced class compilation to android and iOS prod builds. Both this PR and #8252 makes loading of js ~35% faster comparing to release version.
testing notes:
In order to compare startup time:
install the last release version and measure time necessary for loading intro screen
remove app
install this PR's version
measure startup time again
status: ready