Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/on result in app transactions #8297

Merged
merged 1 commit into from
May 29, 2019
Merged

Fix/on result in app transactions #8297

merged 1 commit into from
May 29, 2019

Conversation

yenda
Copy link
Contributor

@yenda yenda commented May 28, 2019 •
edited by StatusWrike
Loading

  • based on @jeluard finding of argument mismatch in wallet/eth-transaction-call function
  • this function is only called in the tribute-to-talk and stickers features to start the transaction flow.
  • this is a typo fix, before the function was expecting on-success and later in the flow on-result was used so nothing was happening on transaction result.

Tests

This doesn't require tests are this is just a typo fix

Currently in non modified builds only stickers can be tested. Here are the steps I tested on Android:
create account on ropsten, get eth and snt, go to #test public chat and buy stickers pack, wait for transaction to be on chain, click on install button, was able to post stickers in the channel
status: ready

@yenda yenda added the sticker label May 28, 2019
@yenda yenda requested a review from a team as a code owner May 28, 2019 16:25
@yenda yenda self-assigned this May 28, 2019
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-im-auto
Copy link
Member

status-im-auto commented May 28, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a2561ec #1 2019-05-28 16:42:51 ~17 min linux 📦 App
✔️ a2561ec #1 2019-05-28 16:44:12 ~18 min windows 📦 exe
✔️ a2561ec #1 2019-05-28 16:44:30 ~19 min macos 📦 dmg
✔️ a2561ec #1 2019-05-28 16:50:02 ~24 min ios 📦 ipa
✔️ a2561ec #1 2019-05-28 16:50:24 ~25 min android 📦 apk
✔️ a2561ec #1 2019-05-28 16:51:08 ~25 min android-e2e 📦 apk
✔️ 513ca85 #2 2019-05-29 14:20:06 ~16 min android 📦 apk
✔️ 513ca85 #2 2019-05-29 14:27:31 ~24 min android-e2e 📦 apk

@flexsurfer
Copy link
Member

flexsurfer commented May 28, 2019 •
edited
Loading

i believe it's a wrong issue number in the description, i'm not sure if @asemiankevich created proper one for this fix

@asemiankevich
Copy link
Contributor

i believe it's a wrong issue number in the description, i'm not sure if @asemiankevich created proper one for this fix

i did not, but @yenda says it is about some sticker issue. Confused now , which issue is fixed here?

@yenda
Copy link
Contributor Author

yenda commented May 29, 2019

@asemiankevich yeah I got it wrong it was about the issue with stickers you found while testing wallet changes

@flexsurfer
Copy link
Member

flexsurfer commented May 29, 2019 •
edited
Loading

#7723 is UI issue, not related to this PR

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 49
Failed tests: 0
Passed tests: 49

Passed tests (49)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_open_transaction_on_etherscan
Device sessions

8. test_public_chat_messaging
Device sessions

9. test_long_press_to_delete_1_1_chat
Device sessions

10. test_password_in_logcat_sign_in
Device sessions

11. test_text_message_1_1_chat
Device sessions

12. test_add_to_contacts
Device sessions

13. test_sign_typed_message (TestRail link is not found)
Device sessions

14. test_unread_messages_counter_1_1_chat
Device sessions

15. test_logcat_send_transaction_from_daap
Device sessions

16. test_send_message_in_group_chat
Device sessions

17. test_logcat_send_transaction_from_wallet
Device sessions

18. test_send_token_with_7_decimals
Device sessions

19. test_modify_transaction_fee_values
Device sessions

20. test_send_eth_from_wallet_to_address
Device sessions

21. test_manage_assets
Device sessions

22. test_logcat_send_transaction_in_1_1_chat
Device sessions

23. test_request_and_receive_eth_in_1_1_chat
Device sessions

24. test_long_press_to_delete_public_chat
Device sessions

25. test_send_emoji
Device sessions

26. test_search_chat_on_home
Device sessions

27. test_logcat_recovering_account
Device sessions

28. test_messaging_in_different_networks
Device sessions

29. test_send_tokens_in_1_1_chat
Device sessions

30. test_network_mismatch_for_send_request_commands
Device sessions

31. test_logcat_sign_message_from_daap
Device sessions

32. test_switch_users_and_add_new_account
Device sessions

33. test_send_stt_from_wallet
Device sessions

34. test_send_eth_in_1_1_chat
Device sessions

35. test_login_with_new_account
Device sessions

36. test_send_eth_from_wallet_to_contact
Device sessions

37. test_add_contact_from_public_chat
Device sessions

38. test_send_two_transactions_one_after_another_in_dapp
Device sessions

39. test_password_in_logcat_creating_account
Device sessions

40. test_backup_recovery_phrase
Device sessions

41. test_offline_status
Device sessions

42. test_open_google_com_via_open_dapp
Device sessions

43. test_unread_messages_counter_public_chat
Device sessions

44. test_sign_message_from_daap
Device sessions

45. test_user_can_remove_profile_picture
Device sessions

46. test_share_contact_code_and_wallet_address
Device sessions

47. test_request_eth_in_wallet
Device sessions

48. test_refresh_button_browsing_app_webview
Device sessions

49. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 49
Failed tests: 0
Passed tests: 49

Passed tests (49)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_open_transaction_on_etherscan
Device sessions

8. test_public_chat_messaging
Device sessions

9. test_long_press_to_delete_1_1_chat
Device sessions

10. test_password_in_logcat_sign_in
Device sessions

11. test_text_message_1_1_chat
Device sessions

12. test_add_to_contacts
Device sessions

13. test_sign_typed_message (TestRail link is not found)
Device sessions

14. test_unread_messages_counter_1_1_chat
Device sessions

15. test_logcat_send_transaction_from_daap
Device sessions

16. test_send_message_in_group_chat
Device sessions

17. test_logcat_send_transaction_from_wallet
Device sessions

18. test_send_token_with_7_decimals
Device sessions

19. test_modify_transaction_fee_values
Device sessions

20. test_send_eth_from_wallet_to_address
Device sessions

21. test_manage_assets
Device sessions

22. test_logcat_send_transaction_in_1_1_chat
Device sessions

23. test_request_and_receive_eth_in_1_1_chat
Device sessions

24. test_long_press_to_delete_public_chat
Device sessions

25. test_send_emoji
Device sessions

26. test_search_chat_on_home
Device sessions

27. test_logcat_recovering_account
Device sessions

28. test_messaging_in_different_networks
Device sessions

29. test_send_tokens_in_1_1_chat
Device sessions

30. test_network_mismatch_for_send_request_commands
Device sessions

31. test_logcat_sign_message_from_daap
Device sessions

32. test_switch_users_and_add_new_account
Device sessions

33. test_send_stt_from_wallet
Device sessions

34. test_send_eth_in_1_1_chat
Device sessions

35. test_login_with_new_account
Device sessions

36. test_send_eth_from_wallet_to_contact
Device sessions

37. test_add_contact_from_public_chat
Device sessions

38. test_send_two_transactions_one_after_another_in_dapp
Device sessions

39. test_password_in_logcat_creating_account
Device sessions

40. test_backup_recovery_phrase
Device sessions

41. test_offline_status
Device sessions

42. test_open_google_com_via_open_dapp
Device sessions

43. test_unread_messages_counter_public_chat
Device sessions

44. test_sign_message_from_daap
Device sessions

45. test_user_can_remove_profile_picture
Device sessions

46. test_share_contact_code_and_wallet_address
Device sessions

47. test_request_eth_in_wallet
Device sessions

48. test_refresh_button_browsing_app_webview
Device sessions

49. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@asemiankevich asemiankevich self-assigned this May 29, 2019
[fix] on-result event for in app transactions
513ca85 
Signed-off-by: yenda <eric@status.im>
@yenda yenda force-pushed the fix/on-result-in-app-transactions branch from a2561ec to 513ca85 Compare May 29, 2019 14:03
@yenda yenda merged commit 513ca85 into develop May 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/on-result-in-app-transactions branch May 29, 2019 14:03
@weekly-digest weekly-digest bot mentioned this pull request Jun 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeluard jeluard jeluard approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

@vitvly vitvly Awaiting requested review from vitvly

Assignees
No one assigned
Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yenda @status-im-auto @flexsurfer @asemiankevich @statustestbot @jeluard