You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
krisc
wants to merge
1
commit into
status-im:develop
from
krisc:qr-scan-error-no-redirect
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, I submitted #7745, but it caused this regression #8044
This PR is the same as #7745 but uses an atom check in src/status_im/ui/screens/qr_scanner/views.cljs
This is a WIP because there is still more work to do:
Another issue came up where after an invalid code is scanned, after dismissing the error message another QR code can be scanned (confirmed that the :barcode-read? screen paramater is indeed toggled), but an error message does not show up.
The :qr-scanner.ui/qr-code-error-dismissed event is not yet fired when opening the QR scanner from starting a new chat. This changed from when I submitted my original PR. It used to be in src/status_im/contact/core.cljs but not anymore. If anyone can direct me where it is now, that would be greatly appreciated.
My sincerest apologies that it's taking so long. Ever since we switched to nix, I've been struggling with building and running the app for testing. I follow these steps as my development flow. I'm using my android phone to test:
make android-ports
make startdev-android-real
make react-native-android
make run-android
open http://localhost:4567/ in my browser for re-frisk
Somewhere in this process, my laptop usually freezes. If anyone has any tips for me, that would be greatly appreciated. However, it may be that my laptop is just too old and slow :(
@krisc can you provide some more details, like laptop hardware specs (how much RAM, is the disk an SSD, etc)? You mention that somewhere along the process, the laptop freezes. Can you pinpoint in which of those steps it freezes (make react-native-android, make run-android)?
@krisc can you provide some more details, like laptop hardware specs (how much RAM, is the disk an SSD, etc)? You mention that somewhere along the process, the laptop freezes. Can you pinpoint in which of those steps it freezes (make react-native-android, make run-android)?
The freezing usually happens after make run-android. The app gets launched on my phone, and then the make react-native-android starts loading dependencies (I think that's what's happening?) This is when my laptop freezes. I noticed that it's less likely to freeze when I stop the terminal which ran make startdev-android-real. When the app is finished loading, I just re-run make startdev-android-real and then everything is fine. But if it does freeze, I just keep trying until it doesn't freeze. I think it's just that my laptop is old :/
I mentioned this in the #status-gitoin channel, but I'm participating in the Beyond Blockchain hackathon until July 10th and putting work on these bounties on hold until then.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #5287
Originally, I submitted #7745, but it caused this regression #8044
This PR is the same as #7745 but uses an atom check in
src/status_im/ui/screens/qr_scanner/views.cljsThis is a WIP because there is still more work to do:
:barcode-read?screen paramater is indeed toggled), but an error message does not show up.:qr-scanner.ui/qr-code-error-dismissedevent is not yet fired when opening the QR scanner from starting a new chat. This changed from when I submitted my original PR. It used to be insrc/status_im/contact/core.cljsbut not anymore. If anyone can direct me where it is now, that would be greatly appreciated.