Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter sharing prompt opens both in a new window, and a new tab #19

Open
stefanbohacek opened this issue Dec 12, 2016 · 0 comments
Open
Labels

Comments

@stefanbohacek
Copy link
Owner

stefanbohacek commented Dec 12, 2016

In Firefox (version 50.0.1), when I click the twitter button, it opens both in a new window, and a new tab.

screenshot

As you can see, the one in the tab is missing the Twitter handle, and the one that opens in a new window is missing everything else.

A quick fix for this would be handling the onclick event using addEventListener instead of the inline script, so that you can use preventDefault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant