Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map key .get doesn't match when the key is a complex type #140

Open
kalepail opened this issue Sep 12, 2023 · 1 comment
Open

Map key .get doesn't match when the key is a complex type #140

kalepail opened this issue Sep 12, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@kalepail
Copy link
Contributor

Probably "because JavaScript" but when using the TS bindings when the return type contains a Map where the key is something like an Address providing that key in a .get method it won't return that value for that key.

Map keys likely need to be converted to strings or something other than a complex type where .get requests can fail when the underlying object is actually identical.

@kalepail kalepail added the bug Something isn't working label Sep 12, 2023
@willemneal
Copy link
Member

Another idea would be to create a different Map that does equality checks instead of reference checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants