New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS for license key submission/verification needs to be genericized #27

Open

borkweb opened this issue Aug 8, 2023 · 1 comment

Member

borkweb commented Aug 8, 2023

When license key fields from multiple plugins appear on the same page, we have an issue with the JS tied to those fields not being generic enough.

One approach to solving that is via inline scripts like: #26

Another approach (the preferred) would be to implement more generic script capabilities like those in https://github.com/stellarwp/installer/blob/main/src/assets/js/installer.js

Contributor

jamesckemp commented Aug 8, 2023

+1 for the namespaced route!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment