Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation instructions blasts away user config without warning #14

Open
jbedo opened this issue Oct 26, 2021 · 0 comments
Open

Installation instructions blasts away user config without warning #14

jbedo opened this issue Oct 26, 2021 · 0 comments

Comments

@jbedo
Copy link

jbedo commented Oct 26, 2021

The readme currently instructs users to run:

fileConn<-file("~/.R/Makevars")
writeLines(c( "CXX14FLAGS += -O3","CXX14FLAGS += -DSTAN_THREADS", "CXX14FLAGS += -pthread"), fileConn)
close(fileConn)

This blasts away any config a user may already have configured at ~/.R/Makevars and is accompanied with no warnings. Users should be strongly warned that this will happen.

Moreover, the whole instruction could be avoided by detecting platforms and available compiler features in configure. Users would then not have to do anything special to configure the build environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant