Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync-functions crash in node 12 when used in tape-test #88

Open
SockeThe2nd opened this issue Nov 28, 2019 · 0 comments
Open

sync-functions crash in node 12 when used in tape-test #88

SockeThe2nd opened this issue Nov 28, 2019 · 0 comments

Comments

@SockeThe2nd
Copy link

I am using node-etcd to load some settings inside a tape-test but the test crashes with a v8 error.

I am using:

  • Node v12.13.1
  • tape@4.11.0
  • node-etcd@7.0.0

The code runs with node 10, but fails with node 12.

Code:

const test = require('tape');

test('test node-etcd sync', function (t) {
    t.plan(1);
    var Etcd = require('node-etcd');

    var etcdClient = new Etcd();

    etcdClient.mkdirSync('test/');

    etcdClient.setSync(`test/key`, 'value');
    t.ok(true)
});

Output:

TAP version 13
# test node-etcd sync
FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal.
 1: 0x9da7c0 node::Abort() [node]
 2: 0x9db976 node::OnFatalError(char const*, char const*) [node]
 3: 0xb39cea v8::Utils::ReportApiFailure(char const*, char const*) [node]
 4: 0x97ca05 node::Environment::CheckImmediate(uv_check_s*) [node]
 5: 0x12de47c  [node]
 6: 0x12d7073 uv_run [node]
 7: 0x7f4c4f5e2694 Run(Napi::CallbackInfo const&) [/mnt/d/dev/playground/etcd_test/node_modules/deasync/bin/linux-x64-node-12/deasync.node]
 8: 0x7f4c4f5e37cb Napi::details::CallbackData<Napi::Value (*)(Napi::CallbackInfo const&), Napi::Value>::Wrapper(napi_env__*, napi_callback_info__*) [/mnt/d/dev/playground/etcd_test/node_modules/deasync/bin/linux-x64-node-12/deasync.node]   9: 0x98f4d5  [node]
10: 0xba5d59  [node]
11: 0xba7b47 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [node]
12: 0x13750d9  [node]
Aborted (core dumped)

I first thought the problem was the deasync module itself so I testet the examples provided in the deasync-repo but they all worked inside a tape-test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant