Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expandLevel infinity #30

Open
Hurtak opened this issue May 17, 2017 · 2 comments
Open

expandLevel infinity #30

Hurtak opened this issue May 17, 2017 · 2 comments
Labels
enhancement help wanted

Comments

@Hurtak
Copy link
Contributor

Hurtak commented May 17, 2017 •
edited
Loading

Hi,

I would like to propose API change so that the expandLevel also takes Infinity. Currently, it is not possible to set the tree view to the fully expanded state by any other way than by setting expandLevel to some arbitrarily large number.

I also tried Number.MAX_SAFE_INTEGER but that (along with Infinity) causes to throw `Invalid array length'.
@Hurtak
Copy link
Contributor Author

Hurtak commented May 17, 2017 •
edited
Loading

I cannot verify right now because I am at a different computer, but I had some object with like 10 levels, and expanding to all levels with expandLevel=100 was noticeably slower than expandLevel=15. I Will try to investigate more tomorrow.

@ndelangen
Copy link
Member

@Hurtak sounds reasonable enough to me, would you be able to open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ndelangen @Hurtak @CodyReichert