Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stretchr/testify Loading
base: v1.8.1
Choose a base ref
...
head repository: stretchr/testify Loading
compare: v1.8.2
Choose a head ref
  • 5 commits
  • 7 files changed
  • 6 contributors

Commits on Nov 2, 2022

  1. Add sub-tests to Suite (#1246)

    Co-authored-by: Vadym Tishchenko <v.tishchenko@evopay.com.ua>
    qerdcv and Vadym Tishchenko committed Nov 2, 2022
    1 Configuration menu
    Copy the full SHA
    1333b5d View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Configuration menu
    Copy the full SHA
    9acc222 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Fix Call.Unset() panic (issue #1236) (#1250)

    Unset changes len of a `ExpectedCalls` slice during iteration while using index from original slice, and under some conditions it tries to reslice element beyond of the slice boundaries. That causes panic.
    
    The proposed solution uses independent write index to count elements kept in output slice.
    
    Tests (the simplest and more complicated cases) and comments are included.
    lisitsky committed Jan 3, 2023
    1 Configuration menu
    Copy the full SHA
    2b00d33 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ab3ce1 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Fix Subset/NotSubset when map is missing keys from the subset (#1261)

    `MapIndex` returns a zero `reflect.Value` if the map value does not
    exist. This now aligns more closely with `InDeltaMapValues` by
    checking `reflect/Value.IsValid`.
    
    The use of `recover()` was hiding this error by setting the result of
    the test to be "false" despite the test suite passing. This led to
    flapping tests where they would succeed if the panic occurred on a
    missing key before comparing key values that didn't match!
    
    I've ensured the test suite now asserts on the expected error message
    and added another example where the subset has keys not found on the
    map under test.
    danielwhite committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    f36bfe3 View commit details
    Browse the repository at this point in the history
Loading