Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DanRoscigno/docker-w3c-checklink
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: stupchiy/docker-w3c-checklink
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 3 contributors

Commits on Aug 11, 2024

  1. fix: add curl dependency (stupchiy#5) 

    The `RUN` directive that downloads the link checker distribution uses `curl` to do so but the `apt-get` commands that run earlier don't actually install `curl`. This fixes that to avoid this error:

```
 => ERROR [3/3] RUN set -x   && curl -sSL https://github.com/w3c/link-checker/archive/checklink-4_81.tar.gz -o /tmp/link-checker.tar.gz   && mkdir -p /usr/src   && tar -xzf /tm  0.1s
------
 > [3/3] RUN set -x   && curl -sSL https://github.com/w3c/link-checker/archive/checklink-4_81.tar.gz -o /tmp/link-checker.tar.gz   && mkdir -p /usr/src   && tar -xzf /tmp/link-checker.tar.gz -C /usr/src   && rm /tmp/link-checker.tar.gz   && cd /usr/src/link-checker-checklink-4_81   && cpanm --installdeps .   && cpanm LWP::Protocol::https   && perl Makefile.PL   && make   && make test   && make install   && rm -rf /usr/src/link-checker-checklink-4_81:
0.105 + curl -sSL https://github.com/w3c/link-checker/archive/checklink-4_81.tar.gz -o /tmp/link-checker.tar.gz
0.105 /bin/sh: 1: curl: not found
```
    @eventualbuddha
    eventualbuddha committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    b1f6ba3 View commit details
    Browse the repository at this point in the history

  2. Ensure curl and zlib1g-dev are installed (stupchiy#4) 

    * Ensure `curl` is installed

Fixes error:
```shell
=> ERROR [3/3] RUN set -x   && curl -sSL https://github.com/w3c/link-checker/archive/checklink-4_81.tar.gz -o /tmp/link-checker.tar.gz   && mkdir -p /usr/src   && tar -xzf /tmp/link-checker.tar.gz -C /usr/src   && rm /tmp/link-checker.tar.gz     0.4s
------
 > [3/3] RUN set -x   && curl -sSL https://github.com/w3c/link-checker/archive/checklink-4_81.tar.gz -o /tmp/link-checker.tar.gz   && mkdir -p /usr/src   && tar -xzf /tmp/link-checker.tar.gz -C /usr/src   && rm /tmp/link-checker.tar.gz   && cd /usr/src/link-checker-checklink-4_81   && cpanm --installdeps .   && cpanm LWP::Protocol::https   && perl Makefile.PL   && make   && make test   && make install   && rm -rf /usr/src/link-checker-checklink-4_81:
0.357 + curl -sSL https://github.com/w3c/link-checker/archive/checklink-4_81.tar.gz -o /tmp/link-checker.tar.gz
0.357 /bin/sh: 1: curl: not found
------
Dockerfile:17
```

* ensure `zlib1g-dev` installed

---------

Co-authored-by: Sergiy Tupchiy <stupchiy@gmail.com>
    @bhamail @stupchiy
    bhamail and stupchiy committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    6e27a62 View commit details
    Browse the repository at this point in the history
Loading