-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store only the changed settings in the advanced settings.txt #3237
Comments
While searching for content for helix-editor/helix#396 (comment) , just found out that Python does this too:
|
MuPDF itself hides (nix like) the history settings in user root thus not very useful as a portable app, SumatraPDF Portable keeps portable settings file in exe folder like most Traditional PortApps did/do (there can be problems with other moder PortableApp Clones that use multiple ini regs and dat's.) The historic settings were not exposed as a txt type file but a dat file for only application but over time extra user acessible features have been added so as to keep sessions against failure in that same one control set. The set could be made inaccessible like MuPDF to avoid interference, but as it stands almost one file fits all. (exception is the thumbnails error or runtime or crash logs, etc.) |
Too much work for the benefit. Also, having all the settings listed in the file educates people about what the settings are. |
This idea was on my mind for quite a long time; was a bit unsure earlier, but I got confirmed that it is correct when i saw an actual implementation of it in the config file of helix editor.
So, currently, sumatra stores all the settings in the
SumatraPDF-settings.txt
- and rewrites them everywhere a setting is changed from UI and at various other triggers/events I suppose.The suggestion is to internally store a default configuration, and append (i.e. write at end) the
SumatraPDF-settings.txt
with only those settings which are changed. This approach is used by various TUI based applications, and is really helpful.It will also allow #3043 and will ease the process for running with default config for diagnosing bugs.
This will require #1174
The text was updated successfully, but these errors were encountered: