Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 1.8-compatible JSON compilation database support #77

Merged
merged 14 commits into from
Apr 8, 2014
Merged

Add Ruby 1.8-compatible JSON compilation database support #77

merged 14 commits into from
Apr 8, 2014

Conversation

kattrali
Copy link
Contributor

@kattrali kattrali commented Apr 8, 2014

Extends #61

Additions

  • Vendors generator.rb and parser.rb from the json_pure gem, loading only when no default JSON implementation is found
    • generator.rb is loaded during database generation and handles writing the file
    • parser.rb is loaded during feature runs to inspect test output

neonichu and others added 14 commits April 4, 2014 14:21
@neonichu @kattrali
Basically working, doesn't contain absolute paths for file and direct…
50a296f 
…ory.
@neonichu @kattrali
Remove whitespace in front of compiler commands.
1074c56
@neonichu @kattrali
Added feature tests for the JSON compilation database reporter.
bf07eef
@neonichu @kattrali
Updated README with json-compilation-database.
8cf07ca
@neonichu @kattrali
Split up JSON db tests, moved magic number to constant.
67fe77b
@neonichu @kattrali
Added spec for format_compile_command()
7d29196
@neonichu @kattrali
Use workaround for http://luan-itworld.blogspot.de/2013/08/ruby-undef…
d0c696b 
…ined-method-for.html
@neonichu @kattrali
Use json_pure on older rubies if available.
6d0fe45
@neonichu @kattrali
Added missing require json.
b7774f4
@neonichu @kattrali
Install json_pure to make tests work for ruby 1.8.7
89d7b41
@kattrali
vendor JSON generator/parser for ruby 1.8
ffe2fb9 
* Use json in stdlib for ruby 1.9+
* Change dashes in file names to underscores to match convention
@kattrali
Clean up files after feature runs
f7aa666
@kattrali
Simplify steps
1ee2658
@kattrali
Fix relative path loading
dbc2909
supermarin pushed a commit that referenced this pull request Apr 8, 2014
Merge pull request #77 from supermarin/json-db
9364f84 
Add Ruby 1.8-compatible JSON compilation database support
@supermarin supermarin merged commit 9364f84 into master Apr 8, 2014
@supermarin supermarin mentioned this pull request Apr 8, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kattrali @supermarin @neonichu