Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom mode storage key only partially respected #93

Open
zerosym opened this issue Aug 10, 2024 · 1 comment
Open

Custom mode storage key only partially respected #93

zerosym opened this issue Aug 10, 2024 · 1 comment

Comments

@zerosym
Copy link

zerosym commented Aug 10, 2024

Describe the bug

After setting custom values for both theme and mode storage keys (and clearing my local storage) I noticed that the default mode-watcher-mode key still appears in addition to the custom ones.

export function setInitialMode({

Just a quick glance at the code and it seems in the setup function the keys are still hardcoded strings rather than using the parameters.

Reproduction

 <ModeWatcher themeStorageKey="my-theme" modeStorageKey="my-mode" />

Logs

No response

System Info

npmPackages:
    @sveltejs/kit: ^2.0.0 => 2.5.17
    mode-watcher: ^0.4.1 => 0.4.1
    svelte: ^5.0.0-next.208 => 5.0.0-next.208

Severity

annoyance

@zerosym
Copy link
Author

zerosym commented Aug 12, 2024

Noticed #89 includes a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant