feat(estree/compat): Remove dependency on rayon

[dsherret]

Description: Adds a concurrent feature to swc_estree_compat so this can be used without rayon.

Related issue (if exists): None

[changeset-bot]

🦋 Changeset detected

Latest commit: 214f7d5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[kdy1]

CI failed

[codspeed-hq]

CodSpeed Performance Report

Merging #9393 will degrade performances by 4.29%

_{Comparing dsherret:swc_estree_compat (214f7d5) with main (1bf467d)}

Summary

⚡ 3 improvements
❌ 1 regressions
✅ 174 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	dsherret:swc_estree_compat	Change
⚡	es/full/bugs-1	558.8 µs	536.4 µs	+4.18%
❌	common/allocator/alloc/cached-no-scope/1000000	108.6 ms	113.5 ms	-4.29%
⚡	parse_and_babelify_jquery	113.9 ms	110.6 ms	+3.01%
⚡	parse_and_babelify_underscore	15.7 ms	15.2 ms	+3.51%

[dsherret]

It seems to be an existing issue on main that the CI is now running because of the new concurrent feature.

% git switch main
Switched to branch 'main'
% cargo test -p swc_estree_compat --bench babelify                      
    Blocking waiting for file lock on build directory

...

Gnuplot not found, using plotters backend
Testing babelify-only
Success

Testing parse_and_babelify_angular
Success

Testing parse_and_babelify_backbone
Success

Testing parse_and_babelify_jquery
Success

Testing parse_and_babelify_jquery_mobile

thread '<unknown>' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p swc_estree_compat --bench babelify`

Caused by:
  process didn't exit successfully: `/Users/david/dev/swc/target/debug/deps/babelify-b3c33d587b84ea1e` (signal: 6, SIGABRT: process abort signal)

[kdy1]

The main branch works, and I think it works because rayon creates another stack. You may use stacker to adjust stack size dynamically.

[dsherret]

The main branch works

Are you sure? It's failing for me.

% cargo test -p swc_estree_compat --bench babelify                      
...
Testing parse_and_babelify_jquery_mobile

thread '<unknown>' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p swc_estree_compat --bench babelify`

Caused by:
  process didn't exit successfully: `/Users/david/dev/swc/target/debug/deps/babelify-b3c33d587b84ea1e` (signal: 6, SIGABRT: process abort signal)
swc % git status                                                            
On branch main

[kdy1]

CI for main branch passes

[kdy1]

See https://github.com/swc-project/swc/actions/runs/10291509450/job/28484028119

[kdy1]

The default stack size of linux is different from the one of macos

[dsherret]

It doesn't seem to run this test on the CI on main because main doesn't have a concurrent feature: https://productionresultssa9.blob.core.windows.net/actions-results/fd9089d3-f3cd-4e56-bb32-566ffa489f30/workflow-job-run-df2dbde4-2171-57ef-1d95-40d5fbea4950/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-08-07T21%3A42%3A00Z&sig=ADucjSzS4esyerQHiZ1D0Ur%2F2xwXrf%2FqJvMMDH4o0sg%3D&ske=2024-08-08T05%3A57%3A38Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2024-08-07T17%3A57%3A38Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2024-05-04&sp=r&spr=https&sr=b&st=2024-08-07T21%3A31%3A55Z&sv=2024-05-04

This if statement will not be true on main:

swc/scripts/github/test-concurrent.sh

Line 16 in d479cc2

if [[ $CRATES == *"$1"* ]]; then

[dsherret]

I'm just saying it's an existing issue on main (not CI). I can look into fixing it tomorrow, though I'm not sure exactly how to do that (I'll look at how stacker is used elsewhere).

[kdy1]

I'll take on this on Monday

[dsherret]

Ok thanks! I tried a bit and couldn't figure it out 😅