From 9c997a8dc4fac30bc352f5f04606fa944e2cc455 Mon Sep 17 00:00:00 2001 From: Nate Wright Date: Thu, 29 Sep 2022 11:50:44 +0100 Subject: [PATCH] pkp/pkp-lib#8299 Fix representation policy --- .../authorization/internal/RepresentationRequiredPolicy.inc.php | 2 +- classes/submission/RepresentationDAO.inc.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/classes/security/authorization/internal/RepresentationRequiredPolicy.inc.php b/classes/security/authorization/internal/RepresentationRequiredPolicy.inc.php index e7990d29e4..db98b12f1c 100644 --- a/classes/security/authorization/internal/RepresentationRequiredPolicy.inc.php +++ b/classes/security/authorization/internal/RepresentationRequiredPolicy.inc.php @@ -46,7 +46,7 @@ function dataObjectEffect() { // Make sure the representation belongs to the submission. $representationDao = Application::getRepresentationDAO(); - $representation = $representationDao->getById($representationId, $publication->getId(), null); + $representation = $representationDao->getById($representationId, $publication->getId()); if (!is_a($representation, 'Representation')) return AUTHORIZATION_DENY; // Save the representation to the authorization context. diff --git a/classes/submission/RepresentationDAO.inc.php b/classes/submission/RepresentationDAO.inc.php index 1b72ec5949..ec0284328e 100644 --- a/classes/submission/RepresentationDAO.inc.php +++ b/classes/submission/RepresentationDAO.inc.php @@ -20,7 +20,7 @@ abstract class RepresentationDAO extends DAO { * @param $representationId int Representation ID. * @param $publicationId int Optional publication ID. * @param $contextId int Optional context ID. - * @return DAOResultFactory + * @return Representation */ abstract function getById($representationId, $publicationId = null, $contextId = null);