From 5801f70d42db4de8bf381a09e0d155cfc979deca Mon Sep 17 00:00:00 2001 From: Nate Wright Date: Wed, 8 Mar 2023 09:31:44 +0000 Subject: [PATCH] pkp/pkp-lib#8437 Update db _settings table comments after review --- classes/migration/install/CommonMigration.php | 4 ++-- classes/migration/install/ControlledVocabMigration.php | 2 +- classes/migration/install/GenresMigration.php | 2 +- classes/migration/install/RolesAndUserGroupsMigration.php | 2 +- classes/migration/install/SubmissionsMigration.php | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/classes/migration/install/CommonMigration.php b/classes/migration/install/CommonMigration.php index efb30819e0..7b90a4a1ff 100644 --- a/classes/migration/install/CommonMigration.php +++ b/classes/migration/install/CommonMigration.php @@ -97,7 +97,7 @@ public function up(): void } Schema::create('user_settings', function (Blueprint $table) { - $table->comment('Localized data about users, like their name and affiliation.'); + $table->comment('More data about users, including localized properties like their name and affiliation.'); $table->bigInteger('user_id'); $table->foreign('user_id')->references('user_id')->on('users')->onDelete('cascade'); $table->index(['user_id'], 'user_settings_user_id'); @@ -220,7 +220,7 @@ public function up(): void }); Schema::create('email_templates_settings', function (Blueprint $table) { - $table->comment('Localized data about custom email templates, such as the subject and body.'); + $table->comment('More data about custom email templates, including localized properties such as the subject and body.'); $table->bigInteger('email_id'); $table->foreign('email_id', 'email_templates_settings_email_id')->references('email_id')->on('email_templates')->onDelete('cascade'); $table->index(['email_id'], 'email_templates_settings_email_id'); diff --git a/classes/migration/install/ControlledVocabMigration.php b/classes/migration/install/ControlledVocabMigration.php index 13e6fff1f5..6918a5e041 100644 --- a/classes/migration/install/ControlledVocabMigration.php +++ b/classes/migration/install/ControlledVocabMigration.php @@ -48,7 +48,7 @@ public function up(): void // Controlled vocabulary entry settings Schema::create('controlled_vocab_entry_settings', function (Blueprint $table) { - $table->comment('Localized data about a controlled vocabulary entry, such as the actual word or phrase.'); + $table->comment('More data about a controlled vocabulary entry, including localized properties such as the actual word or phrase.'); $table->bigInteger('controlled_vocab_entry_id'); $table->foreign('controlled_vocab_entry_id', 'c_v_e_s_entry_id')->references('controlled_vocab_entry_id')->on('controlled_vocab_entries')->onDelete('cascade'); $table->index(['controlled_vocab_entry_id'], 'c_v_e_s_entry_id'); diff --git a/classes/migration/install/GenresMigration.php b/classes/migration/install/GenresMigration.php index b850d20a8c..a409e225a7 100644 --- a/classes/migration/install/GenresMigration.php +++ b/classes/migration/install/GenresMigration.php @@ -47,7 +47,7 @@ public function up(): void // Genre settings Schema::create('genre_settings', function (Blueprint $table) { - $table->comment('Localized data about file genres, such as the genre name.'); + $table->comment('More data about file genres, including localized properties such as the genre name.'); $table->bigInteger('genre_id'); $table->foreign('genre_id')->references('genre_id')->on('genres')->onDelete('cascade'); $table->index(['genre_id'], 'genre_settings_genre_id'); diff --git a/classes/migration/install/RolesAndUserGroupsMigration.php b/classes/migration/install/RolesAndUserGroupsMigration.php index d117b57205..61619b669d 100644 --- a/classes/migration/install/RolesAndUserGroupsMigration.php +++ b/classes/migration/install/RolesAndUserGroupsMigration.php @@ -38,7 +38,7 @@ public function up(): void }); Schema::create('user_group_settings', function (Blueprint $table) { - $table->comment('Localized data about user groups, such as the name.'); + $table->comment('More data about user groups, including localized properties such as the name.'); $table->bigInteger('user_group_id'); $table->string('locale', 14)->default(''); $table->string('setting_name', 255); diff --git a/classes/migration/install/SubmissionsMigration.php b/classes/migration/install/SubmissionsMigration.php index d7d0909250..f09ed08b83 100644 --- a/classes/migration/install/SubmissionsMigration.php +++ b/classes/migration/install/SubmissionsMigration.php @@ -74,7 +74,7 @@ public function up(): void // publication metadata Schema::create('publication_settings', function (Blueprint $table) { - $table->comment('Localized data about publications, such as the title and abstract.'); + $table->comment('More data about publications, including localized properties such as the title and abstract.'); // The foreign key relationship on this table is defined with the publications table. $table->bigInteger('publication_id'); @@ -111,7 +111,7 @@ public function up(): void // Language dependent author metadata. Schema::create('author_settings', function (Blueprint $table) { - $table->comment('Localized data about authors, such as their name and affiliation.'); + $table->comment('More data about authors, including localized properties such as their name and affiliation.'); $table->bigInteger('author_id'); $table->foreign('author_id', 'author_settings_author_id')->references('author_id')->on('authors')->onDelete('cascade'); $table->index(['author_id'], 'author_settings_author_id');