Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/http-kernel
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.4.43
Choose a base ref
...
head repository: symfony/http-kernel
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.4.44
Choose a head ref
  • 10 commits
  • 28 files changed
  • 4 contributors

Commits on Feb 7, 2022

  1. [HttpKernel] [HttpCache] Don't throw on 304 Not Modified

    @aleho
    aleho committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    afa0877 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2022

  1. Bump Symfony version to 4.4.44

    @fabpot
    fabpot committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    c54ca38 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. CS fixes

    @nicolas-grekas
    nicolas-grekas committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    3503e3e View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. Fix CS

    @fabpot
    fabpot committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    eefc100 View commit details
    Browse the repository at this point in the history

  2. bug #43998 [HttpKernel] [HttpCache] Don't throw on 304 Not Modified (… 

    …aleho)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] [HttpCache] Don't throw on 304 Not Modified

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fixes  #43997
| License       | MIT
| Doc PR        | ~

If the response cache keeps a `Last-Modified` header clients will request with `If-Modified-Since`.
The surrogate will not handle a `304 Not Modified` correctly, resulting in a 500 and a failed request.

This fixes that request / response cycle, as observed in testing PR #42355.

Commits
-------

d27f02a1a1 [HttpKernel] [HttpCache] Don't throw on 304 Not Modified
    @fabpot
    fabpot committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    2b775e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Workaround disabled "var_dump"

    @nicolas-grekas
    nicolas-grekas committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    91c2abb View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. [HttpKernel] Fix non-scalar check in surrogate fragment renderer

    @aschempp @nicolas-grekas
    aschempp authored and nicolas-grekas committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    3613724 View commit details
    Browse the repository at this point in the history

  2. bug #47073 [HttpKernel] Fix non-scalar check in surrogate fragment re… 

    …nderer (aschempp)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Fix non-scalar check in surrogate fragment renderer

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #46152
| License       | MIT
| Doc PR        | -

Commits
-------

6b85cfd0e6 [HttpKernel] Fix non-scalar check in surrogate fragment renderer
    @nicolas-grekas
    nicolas-grekas committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    906caac View commit details
    Browse the repository at this point in the history

  3. [HttpKernel] Fix test sensitivity on xdebug.file_link_format

    @nicolas-grekas
    nicolas-grekas committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    60f7b05 View commit details
    Browse the repository at this point in the history

  4. Update VERSION for 4.4.44

    @fabpot
    fabpot committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    9e44444 View commit details
    Browse the repository at this point in the history
Loading