From e897b188097756676a3ab988ac2913e64f238e45 Mon Sep 17 00:00:00 2001 From: parodime Date: Thu, 26 Sep 2024 14:02:56 -0400 Subject: [PATCH] no empty sender recip [SLT-184] (#3171) * no empty sender/to addrs [SLT-184] * enable tests * code reformat --- packages/contracts-rfq/contracts/FastBridgeV2.sol | 1 + packages/contracts-rfq/test/FastBridgeV2.Src.t.sol | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/contracts-rfq/contracts/FastBridgeV2.sol b/packages/contracts-rfq/contracts/FastBridgeV2.sol index adf48dd1f3..a8a6f819e7 100644 --- a/packages/contracts-rfq/contracts/FastBridgeV2.sol +++ b/packages/contracts-rfq/contracts/FastBridgeV2.sol @@ -80,6 +80,7 @@ contract FastBridgeV2 is Admin, IFastBridgeV2, IFastBridgeV2Errors { // check bridge params if (params.dstChainId == block.chainid) revert ChainIncorrect(); if (params.originAmount == 0 || params.destAmount == 0) revert AmountIncorrect(); + if (params.sender == address(0) || params.to == address(0)) revert ZeroAddress(); if (params.originToken == address(0) || params.destToken == address(0)) revert ZeroAddress(); if (params.deadline < block.timestamp + MIN_DEADLINE_PERIOD) revert DeadlineTooShort(); diff --git a/packages/contracts-rfq/test/FastBridgeV2.Src.t.sol b/packages/contracts-rfq/test/FastBridgeV2.Src.t.sol index 6e433a1274..05844821e7 100644 --- a/packages/contracts-rfq/test/FastBridgeV2.Src.t.sol +++ b/packages/contracts-rfq/test/FastBridgeV2.Src.t.sol @@ -275,14 +275,12 @@ contract FastBridgeV2SrcTest is FastBridgeV2Test { } function test_bridge_revert_zeroSender() public { - vm.skip(true); // TODO: unskip when fixed tokenParams.sender = address(0); vm.expectRevert(ZeroAddress.selector); bridge({caller: userA, msgValue: 0, params: tokenParams}); } function test_bridge_revert_zeroRecipient() public { - vm.skip(true); // TODO: unskip when fixed tokenParams.to = address(0); vm.expectRevert(ZeroAddress.selector); bridge({caller: userA, msgValue: 0, params: tokenParams});