-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tailwind preset improvements #862
Comments
I'm guessing by "aliases" you mean adding keys to match based on the current keys to prevent breaking changes? |
Yes exactly! 👍 Essentially: let fontSizes = [...]
fontSizes.lg = 2;
let colors = {...};
colors.purple.500 = colors.purple[5]; In that way, you can choose whether you want to use the underlying system tailwind-style (if you're used to their classnames already) or theme-ui style. |
iirc this was just copied over from the other presets (maybe too be coherent?) |
Should be copied from Tailwind, no? 🤔 |
Edited my message to clarify Yeah, even though this will be a breaking change, this should be done IMO if this is called the "tailwind preset". Jackson might have some opinions on that. |
I strongly think if it's the Tailwind preset it should use the Tailwind system, not half of the Tailwind system and half random values 😉 |
If you want to use a lesser spacing scale, that's fine, but yeah it'd be a breaking change and would potentially make the preset less interoperable with other Theme UI presets |
That's a good point 👍 And I personally haven't missed Tailwind's scale. |
Uhh nice, thanks for the mention @mxstbr Next to the issue with the colors, I found out as well that values from Also extending min/max sizes with our custom size variables, but thats personal opinion I guess. Note: My issues are probably within |
Should also update with the new Tailwind 2 color palette 👍 |
Closed by #2357! |
In order to make the Tailwind preset more approachable for people that already know Tailwind, we should:
lg
=2
)purple.5
===purple.500
The text was updated successfully, but these errors were encountered: