Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm-cov and nextest arguments in "inverted" positions #151

Closed
azriel91 opened this issue Apr 11, 2022 · 2 comments · Fixed by #197
Closed

llvm-cov and nextest arguments in "inverted" positions #151

azriel91 opened this issue Apr 11, 2022 · 2 comments · Fixed by #197
Labels
A-nextest Area: nextest integration https://github.com/nextest-rs/nextest C-bug Category: related to a bug.

Comments

@azriel91
Copy link

azriel91 commented Apr 11, 2022

Heya, I'm trying cargo-llvm-cov 0.3.0 with nextest in a workspace, and it appears that:

  • arguments for the cargo llvm-cov application need to be after the nextest subcommand, and
  • arguments for nextest need to be passed before nextest

Example:

nextest_args=(--workspace)
llvm_cov_args=(--workspace --open --output-dir ./target/coverage)

# Passes llvm_cov_args through to nextest, doesn't do what is expected
# This is how I would expect to write the command
cargo llvm-cov $llvm_cov_args[@] nextest $nextest_args[@]

# This does what is expected
cargo llvm-cov $nextest_args[@] nextest $llvm_cov_args[@]

I haven't managed to figure out whether it's by design by clap.

@taiki-e
Copy link
Owner

taiki-e commented Apr 11, 2022

Yeah, support for passthrough arguments has some bugs: see also #144 (comment) and #144 (comment)

The proposed (and accepted) fix is #144 (comment), but has not yet been implemented.

@taiki-e
Copy link
Owner

taiki-e commented Sep 10, 2022

The fix has been published in 0.5.0

@taiki-e taiki-e mentioned this issue Mar 30, 2023
@taiki-e taiki-e added the A-nextest Area: nextest integration https://github.com/nextest-rs/nextest label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-nextest Area: nextest integration https://github.com/nextest-rs/nextest C-bug Category: related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants