Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ConfigReader): Add better ServerError support to ConfigReader errors #1152

Closed
wants to merge 7 commits into from
Closed

chore(ConfigReader): Add better ServerError support to ConfigReader errors #1152

wants to merge 7 commits into from

Conversation

mogery
Copy link
Contributor

@mogery mogery commented Feb 8, 2024

Summary:
This PR adds better ServerError support to ConfigReader, like described in #1105. This PR allows us to convert the result of ConfigReader fns as deep as the used libraries let us. Some reworks of ValidationError, Cause, and omitting the use of anyhow::Error were needed.

Issue Reference(s):
Fixes #1105
/claim #1105

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@algora-pbc algora-pbc bot mentioned this pull request Feb 8, 2024
Closed
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Feb 8, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.57196% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 88.49%. Comparing base (ae51707) to head (a6c0ec6).
Report is 29 commits behind head on main.

❗ Current head a6c0ec6 differs from pull request most recent head ddb486a. Consider uploading reports for the commit ddb486a to get more accurate results

Files Patch % Lines
src/config/config.rs 95.20% 6 Missing ⚠️
src/config/reader.rs 96.34% 3 Missing ⚠️
src/valid/cause.rs 94.59% 2 Missing ⚠️
src/valid/error.rs 96.15% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
+ Coverage   88.35%   88.49%   +0.13%     
==========================================
  Files         105      105              
  Lines       11819    12027     +208     
==========================================
+ Hits        10443    10643     +200     
- Misses       1376     1384       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mogery mogery marked this pull request as draft February 8, 2024 20:56
@mogery
Copy link
Contributor Author

mogery commented Feb 8, 2024

Drafting this because a lot of the changes are actually completely unnecessary. Will rework.

@mogery mogery marked this pull request as ready for review February 10, 2024 11:44
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Feb 15, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Feb 17, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Feb 19, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Feb 21, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Feb 23, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 5 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Feb 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

PR closed after 5 days of inactivity.

@github-actions github-actions bot closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🙋 Bounty claim state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better Json Support for ValidationError
1 participant
@mogery