Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Investigate collator rewards when session has unpredictable block count #74

Closed
Tracked by #16
1xstj opened this issue Oct 19, 2022 · 3 comments
Closed
Tracked by #16

Comments

@1xstj
Copy link
Contributor

1xstj commented Oct 19, 2022

We have observed that sometimes DKG can lag with key upload, also considering that session does not rotate until dkgkey and nextDkgKey are updated this can lead to different block counts for some sessions.

Our collator reward logic depends/assumes all sessions having an equal number of blocks, we need to investigate what sideeffect this new session rotation logic has on collator rewards and maybe redesign the rewards logic.

@dutterbutter dutterbutter changed the title Investigate collator rewards when session has unpredictable block count [TASK] Investigate collator rewards when session has unpredictable block count Oct 24, 2022
@1xstj
Copy link
Contributor Author

1xstj commented Nov 11, 2022

Adding more info, as part of parachain staking pallet we now store RoundInfo, https://github.com/webb-tools/tangle/blob/48a8935a0d5ec26e72c1a90b04b03697e5e9179f/pallets/parachain-staking/src/types.rs#L1576

This has details on which block the round started and when it ended, perhaps this could be useful here.

@dutterbutter dutterbutter changed the title [TASK] Investigate collator rewards when session has unpredictable block count [BUG] Investigate collator rewards when session has unpredictable block count Nov 17, 2022
@drewstone
Copy link
Contributor

The deliverable for this @1xstj should be a document that clearly explains how the rewards work and ends up in the documentation sites.

@1xstj 1xstj self-assigned this Mar 10, 2023
@1xstj
Copy link
Contributor Author

1xstj commented Mar 21, 2023

Closed by tangle-network/webb-docs#85

@1xstj 1xstj closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants