Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: debounced job lock not being removed in extended mode. #2716

Closed
1 task done
lazaroofarrill-opstalent opened this issue Aug 20, 2024 · 6 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@lazaroofarrill-opstalent

Version

5.12.9

Platform

NodeJS

What happened?

When debouncing job in extended mode, lock is not being deleted when the job finishes.

image

All of the jobs corresponding to those locks have finished, yet they are not deleted.

How to reproduce.

send a flow with the structure.

 {
    queueName: 'parent_queue'
    children: [
    {
        queueName: 'child_queue',
        opts: {debounce: 'debounce_id'}
     }]
}

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@roggervalf
Copy link
Collaborator

hi @lazaroofarrill-opstalent, I couldn't reproduce your case, you can maybe take a look at #2717 and change my test case a little bit to reproduce your issue. Btw, using debounce feature could have unexpected behavior as children cannot have more than 1 parent in our current architecture.

@manast
Copy link
Contributor

manast commented Aug 21, 2024

@lazaroofarrill-opstalent I wonder, what is your expected behaviour when using debounce on children?

@brm-anass
Copy link

Hey guys,
I'm using Taskforce, and when I deleted waiting jobs that had a debounce id, their references in the queue under bull:queue_name:de weren't removed. So it prevented new jobs to be created.
I had to delete them manually in order to create new jobs with similar debounce id.

@roggervalf
Copy link
Collaborator

hey @brm-anass I'm adding a test case where I cannot reproduce your issue, could you pls take a look?

@lazaroofarrill
Copy link

lazaroofarrill commented Aug 26, 2024

hi @lazaroofarrill-opstalent, I couldn't reproduce your case, you can maybe take a look at #2717 and change my test case a little bit to reproduce your issue. Btw, using debounce feature could have unexpected behavior as children cannot have more than 1 parent in our current architecture.

the only difference I see in that test is that my jobs have a parentId key and are also inside the children array. They parentId is for the same job though. Would that affect it?

@lazaroofarrill
Copy link

hi @lazaroofarrill-opstalent, I couldn't reproduce your case, you can maybe take a look at #2717 and change my test case a little bit to reproduce your issue. Btw, using debounce feature could have unexpected behavior as children cannot have more than 1 parent in our current architecture.

the only difference I see in that test is that my jobs have a parentId key and are also inside the children array. They parentId is for the same job though. Would that affect it?

@roggervalf
Yes. This was the issue. It would seem having the flows in the children array and also declaring a parent key behaves like having two parents. I can work around that, thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants