Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image is not not being displayed in the website #234

Closed
rahul-n18 opened this issue Mar 15, 2023 · 7 comments
Closed

Image is not not being displayed in the website #234

rahul-n18 opened this issue Mar 15, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@rahul-n18
Copy link

Describe the bug
The described Image is not displayed in the website

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://tattle.co.in/products/ogbv'

Expected behavior
There is expected to be an Image displayed

Screenshots
Screenshot (9)

@rahul-n18 rahul-n18 added the bug Something isn't working label Mar 15, 2023
@rahul-n18
Copy link
Author

Can I work on this Issue as this is my first work in this Repo

@Bhargav-Dave
Copy link
Contributor

Hey @rahul-n18! Thanks for flagging the issue and offering help on the same!

Yes, you can work on the same, the code for that website can actually be found over here: https://github.com/tattle-made/website/blob/master/src/pages/products/ogbv.mdx

The issue it seems is of a broken image link. You can find the image that it references over here: https://github.com/tattle-made/OGBV/blob/main/uli-website/static/Uli_Logo.png

Fork the repo, and create a PR with your changes. Let me know over here if you need some help!

@rahul-n18
Copy link
Author

Sure, and thank you

@rahul-n18
Copy link
Author

Hey @Bhargav-Dave I have made the change in my local code, but I had a doubt i.e, I have created the issue in this repo so can I PR using the same issue or should I create a new Issue in https://github.com/tattle-made/website.

@Bhargav-Dave
Copy link
Contributor

Bhargav-Dave commented Mar 16, 2023

Hi @rahul-n18. It would be great if you can create an issue on the website repository and push your code there. Just paste a link to this issue in the description for documentation purposes. Thanks!

I will close this issues once you create a new one over there

@tarunima
Copy link
Collaborator

@rahul-n18 @Bhargav-Dave should we close this issue?

@Bhargav-Dave
Copy link
Contributor

The issue is fixed here by @rahul-n18: tattle-made/website#107
Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants