Browser Does not remember username and password

[dennyabrain]

Ambika reported that if she saves her username and login on firefox and tries to relogin using that credentials, it doesnt work. she has to relogin everytime.

[dennyabrain]

so, first of all I am not sure if its a browser bug or react bug, since this codebase is not well documented, i was hoping if someone could do some research on it and revert with how this can be fixed.
The UI code for the login page is here - https://github.com/tattle-made/OGBV/blob/main/annotators/annotation-ui/src/pages/login.jsx
we use Grommet for ui components.

[dennyabrain]

fyi, the code for the annotation UI is limited to the annotators folder of this repo.
in the absence of documentation, setting up the backend without my assistance would require understanding of nodejs/express AND sequelize ORM so I am hoping this task can be fixed purely by making changes on the UI layer.

[dennyabrain]

and if that is not possible, then happy to schedule a call to go over setting this up locally and document it in the process.

[Siddhant-K-code]

Related Files to Issues:

• https://github.com/tattle-made/OGBV/blob/6a41e6f094a05540536a798bcbfcd8961d8e831f/annotators/annotation-ui/src/pages/login.jsx#L46
  • https://github.com/tattle-made/OGBV/blob/6a41e6f094a05540536a798bcbfcd8961d8e831f/annotators/annotation-ui/src/controller/login.js#L16
  • https://github.com/tattle-made/OGBV/blob/6a41e6f094a05540536a798bcbfcd8961d8e831f/annotators/annotation-ui/src/repository/user.js#L12

[dennyabrain]

Quick Instructions to get the project running

1. run docker-compose up to bring up the sql database and a database GUI
2. cd into annotators/backend/sequelize and run npx sequelize-cli db:migrate - this will create the tables in db
3. run npx sequelize-cli db:seed --seed 20211115172651-beta-test - this will run the script located here and insert users named tarunima, arnav etc. You will have to check the db to see their password. which is stored in plain text for now.

[dennyabrain]

If this is your first time using sequelize, i suggest spending sometime reading its documentation and specifically this page to familiarise yourself with migrations and seeding

[dennyabrain]

@Siddhant-K-code could you also look into what are the best practices to developing login form. From a cursory research that I did, it seems like if we implement our login section as part of an html form and add the attribute autocomplete to the username and password field, the browser should take care of the rest.
ref : https://www.w3schools.com/TagS/att_input_autocomplete.asp

can you investigate if

1. there's more to it
2. if this fixes this bug

[tarunima]

@dennyabrain can you confirm that this can be closed?

[dennyabrain]

Not yet. Its not fixed yet and we dont have a solution so far

[dennyabrain]

Not relevant anymore