Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.confirm() doesn't show text in firefox #351

Closed
aatmanvaidya opened this issue Aug 31, 2023 · 6 comments
Closed

window.confirm() doesn't show text in firefox #351

aatmanvaidya opened this issue Aug 31, 2023 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers level: ticket: bug tickets that are fixing bugs in existing codebase plugin priority:medium role:frontend size:1pt stale

Comments

@aatmanvaidya
Copy link
Collaborator

window.confirm() doesn't show the text inside in this code block (line 88) on Firefox.

async function clickActivateAccount() {
const { data } = await registerNewUser();
const user = data.user;
const confirmed = window.confirm(
'To start Uli, please refresh the page'
);
if (confirmed) {
await setUserData(user);
setUser(user);
setAccountActivated(true);
await setPreferenceData({
uliEnableToggle: true
});
userBrowserTabs.reload();
navigate('/preferences');
}
}

This is what is happening.

Screenshot (496)

But, window.confirm() shows the text in another code block. In this function on line 109, the text appears in the browser.

const handleToggleSwitchChange = async () => {
try {
const tabsCurrent = await userBrowserTabs.query({
active: true,
currentWindow: true
});
const confirmed = window.confirm(
'Changing the toggle switch setting requires a page reload. Do you want to continue?'
);

Like this

Screenshot (497)

@aatmanvaidya aatmanvaidya added the bug Something isn't working label Aug 31, 2023
@dennyabrain dennyabrain added plugin level: ticket: bug tickets that are fixing bugs in existing codebase priority:medium role:frontend labels Sep 27, 2023
@priyanshtiwari001
Copy link

Hi @aatmanvaidya, I love to work on this issue and try to resolve it. Could you please assign this to me. Thank you!

@aatmanvaidya
Copy link
Collaborator Author

Hello @priyanshtiwari001, yes feel free to take this issue up. I am assigning it to you.

don't hesitate to join our Slack channel and engage with us if you encounter any challenges. (Slack link in the main readme)

@priyanshtiwari001
Copy link

Hi @aatmanvaidya , I can't find the solution of this issue. Kindly please assign to other person. Thank you!

@aatmanvaidya
Copy link
Collaborator Author

Thank you for giving it a shot @priyanshtiwari001, is there anything that we can do from our side to help you out?

If you have any relevant links/ findings that you have made which you think will help the future contributor, please add then to this issue, it will be of great help.

Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Dec 31, 2023
Copy link

github-actions bot commented Apr 4, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers level: ticket: bug tickets that are fixing bugs in existing codebase plugin priority:medium role:frontend size:1pt stale
Projects
None yet
Development

No branches or pull requests

3 participants