-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair github action that publishes extension to chrome #387
Comments
can u assign me this issue |
@Gun2902 I have done so. Good luck! Feel free to reach out if you are stuck. we're happy to help you. |
@Gun2902 , we have some progress that we can share about this issue, we realised that the REFRESH_TOKEN expires and we have to either update the token or manually upload the extension to chrome store. Can you look into other ways and github actions that allow us to automate this? |
Hello @Gun2902, Please don't hesitate to reach out in case you need any help. |
@dennyabrain can we close this issue, as we now know that either we have to update the refresh token or manually upload the extension to chrome store. |
hmmm. I'll close it with some hesitation :P |
if that's the case, should we keep it open and take it up when we have a new release coming up? |
Ha. no let it be. I think this is not a blocker for new releases. As i mentioned above, I would rather do the manual upload everytime (its straightforward) than have to worry about debugging this github action a day before release. If and when we have some bandwidth to do non essential tasks, we can look at this. |
Describe the bug
The github action that we use for publishing the extension to chrome store is brittle. It breaks with the following error :
Full logs can be read here
expand the "Upload to chrome" section
To Reproduce
This workflow has to be triggered manually by someone with write access to the repo. Contact @dennyabrain, @tarunima or @duggalsu
It can be triggered by clicking "Run Workflow" on this page
Expected behavior
Successful completion of the workflow should upload a latest version of the plugin to the chrome store.
Additional context
The code for configuring the action is here :
I am very certain this has to something with the refresh-token parameter. It makes sense that this works sometimes (when the token is active) and fails a week or two later (when the token is expired). But I can't figure out why such a brittle way of doing authentication is part of the action's official documentation. Either i misunderstood the auth flow or did it incorrectly. So in scope of this issue is investigating how to configure this action correctly and might involve reading up about google auth flows.
The text was updated successfully, but these errors were encountered: