Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair github action that publishes extension to chrome #387

Closed
dennyabrain opened this issue Sep 27, 2023 · 8 comments
Closed

Repair github action that publishes extension to chrome #387

dennyabrain opened this issue Sep 27, 2023 · 8 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest level: ticket: bug tickets that are fixing bugs in existing codebase level:ticket An issue that describes a ticket (initiative>feature>ticket) priority:high role:devops size:1pt

Comments

@dennyabrain
Copy link
Contributor

Describe the bug
The github action that we use for publishing the extension to chrome store is brittle. It breaks with the following error :

< HTTP/1.1 100 Continue
} [16384 bytes data]
* We are completely uploaded and fine
* The requested URL returned error: 401 Unauthorized
* Closing connection 0
* TLSv1.2 (OUT), TLS alert, Client hello (1):
} [2 bytes data]
curl: (22) The requested URL returned error: 401 Unauthorized
sh: FAILURE: unknown operand

Full logs can be read here
expand the "Upload to chrome" section

To Reproduce
This workflow has to be triggered manually by someone with write access to the repo. Contact @dennyabrain, @tarunima or @duggalsu
It can be triggered by clicking "Run Workflow" on this page

Expected behavior
Successful completion of the workflow should upload a latest version of the plugin to the chrome store.

Additional context
The code for configuring the action is here :

      - name: "Upload to chrome"
        uses: Klemensas/chrome-extension-upload-action@v1.3
        with:
          refresh-token: ${{ secrets.CHROME_STORE_REFRESH_TOKEN }}
          client-id: ${{ secrets.CHROME_STORE_CLIENT_ID }}
          client-secret: ${{ secrets.CHROME_STORE_CLIENT_SECRET }}
          file-name: "./browser-extension/plugin/extension.zip"
          app-id: "hbfmbflgailjeobfkhpdipcdmpclinki"
          publish: true

I am very certain this has to something with the refresh-token parameter. It makes sense that this works sometimes (when the token is active) and fails a week or two later (when the token is expired). But I can't figure out why such a brittle way of doing authentication is part of the action's official documentation. Either i misunderstood the auth flow or did it incorrectly. So in scope of this issue is investigating how to configure this action correctly and might involve reading up about google auth flows.

@dennyabrain dennyabrain added bug Something isn't working good first issue Good for newcomers hacktoberfest level: ticket: bug tickets that are fixing bugs in existing codebase size:1pt role:devops level:ticket An issue that describes a ticket (initiative>feature>ticket) priority:high labels Sep 27, 2023
@Gun2902
Copy link

Gun2902 commented Oct 4, 2023

can u assign me this issue

@dennyabrain
Copy link
Contributor Author

@Gun2902 I have done so. Good luck! Feel free to reach out if you are stuck. we're happy to help you.

@aatmanvaidya
Copy link
Collaborator

@Gun2902 , we have some progress that we can share about this issue, we realised that the REFRESH_TOKEN expires and we have to either update the token or manually upload the extension to chrome store.

Can you look into other ways and github actions that allow us to automate this?

@aatmanvaidya
Copy link
Collaborator

Hello @Gun2902,
As Hacktoberfest is almost coming to an end, I wanted to check in and see if you're still actively working on the issue. It would be great to know your current status so that we can plan accordingly.

Please don't hesitate to reach out in case you need any help.

@aatmanvaidya
Copy link
Collaborator

@dennyabrain can we close this issue, as we now know that either we have to update the refresh token or manually upload the extension to chrome store.

@dennyabrain
Copy link
Contributor Author

hmmm. I'll close it with some hesitation :P
I feel like we didn't spend enough time inspecting a solution for the refresh token issue. But its also a very low priority thing at this point. Manual upload is the way to go for now \m/

@aatmanvaidya
Copy link
Collaborator

if that's the case, should we keep it open and take it up when we have a new release coming up?

@dennyabrain
Copy link
Contributor Author

Ha. no let it be. I think this is not a blocker for new releases. As i mentioned above, I would rather do the manual upload everytime (its straightforward) than have to worry about debugging this github action a day before release.

If and when we have some bandwidth to do non essential tasks, we can look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest level: ticket: bug tickets that are fixing bugs in existing codebase level:ticket An issue that describes a ticket (initiative>feature>ticket) priority:high role:devops size:1pt
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants