pdftk exited with failure code: 1

[raminious]

Hello,
I have an issue with this module. my code is:

function splitFiles(splits, filepath) {
  return new Promise((resolve, reject) => {
    const writeStream = fs
      .createWriteStream(filepath)
      .on('error', e => reject(e))

    scissors
      .join(...splits)
      .pdfStream()
      .on('error', (e) => reject(e))
      .on('finish', resolve)
      .pipe(writeStream)
  })
}

try {
   await splitFiles(splits, filepath)
} catch(e) {
   console.log(e)
}

the problem is when pdftk can't open one of the files, it kills the server instance instead on throwing a safe error

pdftk: Error: Unable to find file.pdftk:
Error: Failed to open PDF file:
   -
Errors encountered.  No output created.
Done.  Input errors, so no output created.
events.js:182
      throw er; // Unhandled 'error' event
      ^

Error: pdftk exited with failure code: 1
    at ChildProcess.<anonymous> (/opt/node/project/web/node_modules/scissors/scissors.js:586:21)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
[nodemon] app crashed - waiting for file changes before starting...

I can handle this issue by adding stream.on('error', err => console.log(err)) next to line 564

[cboulanger]

Thank you for your report. Can you provide a pull request with this fix?

[cboulanger]

Fixed by 9a0b231

[ThunderBoltEngineer]

Same issue is happening inside Command.prototype._exec function.

I think you should add error handler there as well.

[cboulanger]

Can you provide a PR? I am currently not working on scissors, but will be happy to merge fixes.