From 0b698c1a0f69694d2016379ba4c756f298c3f19d Mon Sep 17 00:00:00 2001 From: Rodrigo Zhou Date: Tue, 14 Feb 2023 16:14:59 -0800 Subject: [PATCH] Wrap user's visibility query string in parenthesis (#3956) --- .../persistence/visibility/store/sql/query_converter_mysql.go | 2 +- .../visibility/store/sql/query_converter_postgresql.go | 2 +- .../persistence/visibility/store/sql/query_converter_sqlite.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/common/persistence/visibility/store/sql/query_converter_mysql.go b/common/persistence/visibility/store/sql/query_converter_mysql.go index de6b2903a02..fd4785e9407 100644 --- a/common/persistence/visibility/store/sql/query_converter_mysql.go +++ b/common/persistence/visibility/store/sql/query_converter_mysql.go @@ -207,7 +207,7 @@ func (c *mysqlQueryConverter) buildSelectStmt( queryArgs = append(queryArgs, namespaceID.String()) if len(queryString) > 0 { - whereClauses = append(whereClauses, queryString) + whereClauses = append(whereClauses, fmt.Sprintf("(%s)", queryString)) } if token != nil { diff --git a/common/persistence/visibility/store/sql/query_converter_postgresql.go b/common/persistence/visibility/store/sql/query_converter_postgresql.go index 9a7f15025c1..2420a40e992 100644 --- a/common/persistence/visibility/store/sql/query_converter_postgresql.go +++ b/common/persistence/visibility/store/sql/query_converter_postgresql.go @@ -214,7 +214,7 @@ func (c *pgQueryConverter) buildSelectStmt( queryArgs = append(queryArgs, namespaceID.String()) if len(queryString) > 0 { - whereClauses = append(whereClauses, queryString) + whereClauses = append(whereClauses, fmt.Sprintf("(%s)", queryString)) } if token != nil { diff --git a/common/persistence/visibility/store/sql/query_converter_sqlite.go b/common/persistence/visibility/store/sql/query_converter_sqlite.go index c94ee41b056..9e6025b625a 100644 --- a/common/persistence/visibility/store/sql/query_converter_sqlite.go +++ b/common/persistence/visibility/store/sql/query_converter_sqlite.go @@ -234,7 +234,7 @@ func (c *sqliteQueryConverter) buildSelectStmt( queryArgs = append(queryArgs, namespaceID.String()) if len(queryString) > 0 { - whereClauses = append(whereClauses, queryString) + whereClauses = append(whereClauses, fmt.Sprintf("(%s)", queryString)) } if token != nil {